Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1841)

Unified Diff: Tools/TestResultServer/model/datastorefile_test.py

Issue 298163003: Fix crash in the flakiness dashboard server. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Tools/TestResultServer/model/datastorefile.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/TestResultServer/model/datastorefile_test.py
diff --git a/Tools/TestResultServer/model/datastorefile_test.py b/Tools/TestResultServer/model/datastorefile_test.py
index 088cd94961651f7240db98a4c7077ab457987479..3ef32847aa36174a4556a86473abb7af188a82e7 100644
--- a/Tools/TestResultServer/model/datastorefile_test.py
+++ b/Tools/TestResultServer/model/datastorefile_test.py
@@ -57,6 +57,19 @@ class DataStoreFileTest(unittest.TestCase):
self.test_file.delete_data()
self.assertFalse(self.test_file.load_data())
+ def testLoadDataInvalidKey(self):
+ test_data = 'x' * datastorefile.MAX_ENTRY_LEN * 3
+
+ self.assertTrue(self.test_file.save_data(test_data))
+ self.assertEqual(test_data, self.test_file.data)
+
+ self.test_file.delete_data()
+ self.assertEqual('', self.test_file.load_data())
+
+ def testLoadDataNoKeys(self):
+ # This should never happen.
+ self.assertEqual(None, self.test_file.load_data())
+
def testSaveData(self):
self.assertFalse(self.test_file.save_data(None))
« no previous file with comments | « Tools/TestResultServer/model/datastorefile.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698