Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Unified Diff: Tools/TestResultServer/model/datastorefile.py

Issue 298163003: Fix crash in the flakiness dashboard server. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Tools/TestResultServer/model/datastorefile_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/TestResultServer/model/datastorefile.py
diff --git a/Tools/TestResultServer/model/datastorefile.py b/Tools/TestResultServer/model/datastorefile.py
old mode 100755
new mode 100644
index 6161c3731394ff4cdb893386cfe7cda1a5bcdaeb..6a1e4f9551ebd1f6dbeca089dcbed96b5fd88f87
--- a/Tools/TestResultServer/model/datastorefile.py
+++ b/Tools/TestResultServer/model/datastorefile.py
@@ -186,7 +186,12 @@ class DataStoreFile(db.Model):
result = future.get_result()
if not result:
logging.error("No data found for key: %s.", key)
- return None
+ # FIXME: This really shouldn't happen, but it seems to be happening in practice.
+ # Figure out how and then change this back to returning None.
+ # In the meantime, return empty string so we at least start collecting
+ # results from new runs even though it'll mean that the old data is lost.
+ # crbug.com/377594
+ return ''
data.append(result)
self.data = "".join([d.data for d in data])
« no previous file with comments | « no previous file | Tools/TestResultServer/model/datastorefile_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698