Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2981473002: config_service: Fixed bug regarding None entries in latest_revisions dict. (Closed)

Created:
3 years, 5 months ago by cwpayton
Modified:
3 years, 5 months ago
Reviewers:
nodir
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

config_service: Fixed bug regarding None entries in latest_revisions dict. Using the include_files option on config sets that had no latest revision number caused a 503 Internal Server Error because there was no check for None entries in the result from get_latest_revisions_async. This cl fixes that by adding a check. BUG=740736 Review-Url: https://codereview.chromium.org/2981473002 Committed: https://github.com/luci/luci-py/commit/32ed948dea48cdeeb11ee7b4d8ab0465837f42c9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M appengine/config_service/api.py View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
cwpayton
PTAL
3 years, 5 months ago (2017-07-11 00:29:33 UTC) #3
nodir
lgtm
3 years, 5 months ago (2017-07-11 21:40:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2981473002/1
3 years, 5 months ago (2017-07-11 21:41:47 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://github.com/luci/luci-py/commit/32ed948dea48cdeeb11ee7b4d8ab0465837f42c9
3 years, 5 months ago (2017-07-11 21:44:24 UTC) #9
nodir
3 years, 5 months ago (2017-07-12 00:43:03 UTC) #10
Message was sent while issue was closed.
the bug should have been 740736

Powered by Google App Engine
This is Rietveld 408576698