Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1725)

Unified Diff: appengine/config_service/api.py

Issue 2981473002: config_service: Fixed bug regarding None entries in latest_revisions dict. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/config_service/api.py
diff --git a/appengine/config_service/api.py b/appengine/config_service/api.py
index 4df01f863b92f4bba595b7c156de4c80af429939..3b0b344c1aa24d18b8b25be23610cc91ff8ee95f 100644
--- a/appengine/config_service/api.py
+++ b/appengine/config_service/api.py
@@ -141,7 +141,7 @@ class ConfigApi(remote.Service):
)
##############################################################################
- # endpoint: get_config_set
+ # endpoint: get_config_sets
class GetConfigSetsResponseMessage(messages.Message):
config_sets = messages.MessageField(ConfigSet, 1, repeated=True)
@@ -170,9 +170,10 @@ class ConfigApi(remote.Service):
'Must specify config_set to use include_files')
latest_revisions = storage.get_latest_revisions_async(
[request.config_set]).get_result()
- file_keys = storage.get_file_keys(
- request.config_set, latest_revisions[request.config_set])
- files = [File(path=key.id()) for key in file_keys]
+ if latest_revisions[request.config_set]:
+ file_keys = storage.get_file_keys(
+ request.config_set, latest_revisions[request.config_set])
+ files = [File(path=key.id()) for key in file_keys]
config_sets = storage.get_config_sets_async(
config_set=request.config_set).get_result()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698