chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc - Issue 2980713002: Views a11y: Obey DialogDelegate::GetAccessibleWindowRole() rather than making a dialog-within-a-dia…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc

Issue 2980713002: Views a11y: Obey DialogDelegate::GetAccessibleWindowRole() rather than making a dialog-within-a-dia… (Closed)

Patch Set: Fix test Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/conflicting_module_view_win.cc ('k') | chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc » ('j') | ui/views/window/dialog_delegate.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc

diff --git a/chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc b/chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc

index 935df03dc4065818751a2059c403ce9190f304ba..696620c549d022b60fe2c9a4fde021a77c625b0c 100644

--- a/chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc

+++ b/chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc

@@ -132,7 +132,7 @@ void ExtensionMessageBubbleViewBrowserTest::ClickLearnMoreButton(

// platform events may happen before the close completes and the dialog needs

// to report a valid state.

ui::AXNodeData node_data;

- bubble->GetAccessibleNodeData(&node_data);

+ bubble->GetWidget()->GetRootView()->GetAccessibleNodeData(&node_data);

EXPECT_EQ(ui::AX_ROLE_DIALOG, node_data.role);

}