Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Unified Diff: chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc

Issue 2980713002: Views a11y: Obey DialogDelegate::GetAccessibleWindowRole() rather than making a dialog-within-a-dia… (Closed)
Patch Set: Fix test Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc
diff --git a/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc b/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc
index b20417acc62a580f26456e5b4f40d2a460216e4d..671dfa826b09958539251bc0f756b69861d8dc7f 100644
--- a/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc
+++ b/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc
@@ -58,11 +58,11 @@ class PermissionsBubbleDialogDelegateView
void CloseBubble();
// BubbleDialogDelegateView:
+ ui::AXRole GetAccessibleWindowRole() const override;
bool ShouldShowCloseButton() const override;
base::string16 GetWindowTitle() const override;
void AddedToWidget() override;
void OnWidgetDestroying(views::Widget* widget) override;
- void GetAccessibleNodeData(ui::AXNodeData* node_data) override;
bool Cancel() override;
bool Accept() override;
bool Close() override;
@@ -147,6 +147,11 @@ void PermissionsBubbleDialogDelegateView::CloseBubble() {
GetWidget()->Close();
}
+ui::AXRole PermissionsBubbleDialogDelegateView::GetAccessibleWindowRole()
+ const {
+ return ui::AX_ROLE_ALERT_DIALOG;
+}
+
bool PermissionsBubbleDialogDelegateView::ShouldShowCloseButton() const {
return true;
}
@@ -177,12 +182,6 @@ void PermissionsBubbleDialogDelegateView::OnWidgetDestroying(
}
}
-void PermissionsBubbleDialogDelegateView::GetAccessibleNodeData(
- ui::AXNodeData* node_data) {
- views::BubbleDialogDelegateView::GetAccessibleNodeData(node_data);
- node_data->role = ui::AX_ROLE_ALERT_DIALOG;
-}
-
int PermissionsBubbleDialogDelegateView::GetDefaultDialogButton() const {
// To prevent permissions being accepted accidentally, and as a security
// measure against crbug.com/619429, permission prompts should not be accepted

Powered by Google App Engine
This is Rietveld 408576698