Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(868)

Unified Diff: chrome/browser/ui/views/conflicting_module_view_win.cc

Issue 2980713002: Views a11y: Obey DialogDelegate::GetAccessibleWindowRole() rather than making a dialog-within-a-dia… (Closed)
Patch Set: Fix test Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/conflicting_module_view_win.cc
diff --git a/chrome/browser/ui/views/conflicting_module_view_win.cc b/chrome/browser/ui/views/conflicting_module_view_win.cc
index 3b5d67168b1eeb102038c2daee6f3730d28e44db..8e2623a6b711060719b7f58e33f99a3ead467277 100644
--- a/chrome/browser/ui/views/conflicting_module_view_win.cc
+++ b/chrome/browser/ui/views/conflicting_module_view_win.cc
@@ -112,6 +112,10 @@ void ConflictingModuleView::ShowBubble() {
bubble_shown.SetValue(bubble_shown.GetValue() + 1);
}
+ui::AXRole ConflictingModuleView::GetAccessibleWindowRole() const {
+ return ui::AX_ROLE_ALERT_DIALOG;
+}
+
void ConflictingModuleView::OnWidgetClosing(views::Widget* widget) {
views::BubbleDialogDelegateView::OnWidgetClosing(widget);
base::RecordAction(
@@ -162,10 +166,6 @@ void ConflictingModuleView::Init() {
EnumerateModulesModel::ACTION_BOUNDARY);
}
-void ConflictingModuleView::GetAccessibleNodeData(ui::AXNodeData* node_data) {
- node_data->role = ui::AX_ROLE_ALERT_DIALOG;
-}
-
void ConflictingModuleView::OnConflictsAcknowledged() {
EnumerateModulesModel* model = EnumerateModulesModel::GetInstance();
if (!model->ShouldShowConflictWarning())

Powered by Google App Engine
This is Rietveld 408576698