Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 2980503002: [Extensions][TaskScheduler] Update ActivityLog for scheduling migration (Closed)

Created:
3 years, 5 months ago by Devlin
Modified:
3 years, 4 months ago
Reviewers:
gab, lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions][TaskScheduler] Update ActivityLog for scheduling migration Migrate the ActivityLog and related classes away from posting tasks to and checking that they are currently on the content::BrowserThread::DB thread, and replace this with a singleton SequencedTaskRunner to be used in the activity log. BUG=689520 Review-Url: https://codereview.chromium.org/2980503002 Cr-Commit-Position: refs/heads/master@{#491137} Committed: https://chromium.googlesource.com/chromium/src/+/6fa6b15543d5e4ce35ac67c8a8fd1dee80d2ceea

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : Experiments #

Total comments: 3

Patch Set 4 : Revert to set for testing #

Patch Set 5 : Revert to set for testing #

Total comments: 4

Patch Set 6 : Use SingleThreadTaskRunner to be safe #

Total comments: 6

Patch Set 7 : gab's #

Patch Set 8 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -66 lines) Patch
M chrome/browser/extensions/BUILD.gn View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/activity_log/activity_database.cc View 1 2 3 4 5 6 7 4 chunks +7 lines, -10 lines 0 comments Download
M chrome/browser/extensions/activity_log/activity_database_unittest.cc View 3 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/extensions/activity_log/activity_log.cc View 1 2 3 4 5 6 7 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/activity_log/activity_log_enabled_unittest.cc View 1 2 3 4 5 6 7 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/activity_log/activity_log_policy.h View 2 chunks +7 lines, -9 lines 0 comments Download
M chrome/browser/extensions/activity_log/activity_log_policy.cc View 1 2 3 4 5 6 7 2 chunks +1 line, -2 lines 0 comments Download
A chrome/browser/extensions/activity_log/activity_log_task_runner.h View 1 2 3 4 5 1 chunk +29 lines, -0 lines 0 comments Download
A chrome/browser/extensions/activity_log/activity_log_task_runner.cc View 1 2 3 4 5 6 1 chunk +36 lines, -0 lines 0 comments Download
M chrome/browser/extensions/activity_log/activity_log_unittest.cc View 1 3 3 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/extensions/activity_log/counting_policy.cc View 4 chunks +7 lines, -15 lines 0 comments Download
M chrome/browser/extensions/activity_log/counting_policy_unittest.cc View 1 2 3 4 5 6 7 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/extensions/activity_log/fullstream_ui_policy.cc View 3 chunks +6 lines, -12 lines 0 comments Download
M chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc View 3 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 55 (35 generated)
Devlin
lazyboy@, please take a look. gab@, please see the question in activity_log_task_runner.h. Cheers! https://codereview.chromium.org/2980503002/diff/20001/chrome/browser/extensions/activity_log/activity_log_task_runner.h File ...
3 years, 5 months ago (2017-07-10 18:48:39 UTC) #7
gab
https://codereview.chromium.org/2980503002/diff/20001/chrome/browser/extensions/activity_log/activity_log_task_runner.h File chrome/browser/extensions/activity_log/activity_log_task_runner.h (right): https://codereview.chromium.org/2980503002/diff/20001/chrome/browser/extensions/activity_log/activity_log_task_runner.h#newcode18 chrome/browser/extensions/activity_log/activity_log_task_runner.h:18: void SetActivityLogTaskRunnerForTesting(base::TaskRunner* task_runner); On 2017/07/10 18:48:39, Devlin wrote: > ...
3 years, 5 months ago (2017-07-12 00:30:22 UTC) #10
Devlin
Hey gab@, mind taking a look at some more questions? Sorry for turning this into ...
3 years, 5 months ago (2017-07-12 19:30:37 UTC) #11
chromium-reviews
Le mer. 12 juil. 2017 12:30, <rdevlin.cronin@chromium.org> a écrit : > Hey gab@, mind taking ...
3 years, 5 months ago (2017-07-14 23:09:24 UTC) #12
gab
On 2017/07/14 23:09:24, chromium-reviews wrote: > Le mer. 12 juil. 2017 12:30, <https://mail.google.com/mail/?view=cm&fs=1&tf=1&to=rdevlin.cronin@chromium.org> a écrit ...
3 years, 5 months ago (2017-07-17 16:58:07 UTC) #13
Devlin
> Sounds like https://bugs.chromium.org/p/chromium/issues/detail?id=739945#c1, > maybe SQL uses TLS or something and needs a SingleThreadTaskRunner ...
3 years, 5 months ago (2017-07-19 20:54:40 UTC) #16
gab
On 2017/07/19 20:54:40, Devlin (OOO through July 24) wrote: > > Sounds like https://bugs.chromium.org/p/chromium/issues/detail?id=739945#c1, > ...
3 years, 5 months ago (2017-07-20 16:15:35 UTC) #19
gab
> > Sounds like https://bugs.chromium.org/p/chromium/issues/detail?id=739945#c1, > > maybe SQL uses TLS or something and needs ...
3 years, 5 months ago (2017-07-20 16:26:43 UTC) #20
Devlin
On 2017/07/20 16:26:43, gab wrote: > > > Sounds like https://bugs.chromium.org/p/chromium/issues/detail?id=739945#c1, > > > maybe ...
3 years, 4 months ago (2017-07-27 13:41:19 UTC) #25
gab
lgtm w/ nits https://codereview.chromium.org/2980503002/diff/100001/chrome/browser/extensions/activity_log/activity_log_task_runner.cc File chrome/browser/extensions/activity_log/activity_log_task_runner.cc (right): https://codereview.chromium.org/2980503002/diff/100001/chrome/browser/extensions/activity_log/activity_log_task_runner.cc#newcode7 chrome/browser/extensions/activity_log/activity_log_task_runner.cc:7: #include "base/sequenced_task_runner.h" single_thread_task_runner.h https://codereview.chromium.org/2980503002/diff/100001/chrome/browser/extensions/activity_log/activity_log_task_runner.cc#newcode9 chrome/browser/extensions/activity_log/activity_log_task_runner.cc:9: #include ...
3 years, 4 months ago (2017-07-27 18:34:53 UTC) #26
Devlin
Thanks for your help, gab@! lazyboy@, mind taking a look? https://codereview.chromium.org/2980503002/diff/100001/chrome/browser/extensions/activity_log/activity_log_task_runner.cc File chrome/browser/extensions/activity_log/activity_log_task_runner.cc (right): https://codereview.chromium.org/2980503002/diff/100001/chrome/browser/extensions/activity_log/activity_log_task_runner.cc#newcode7 ...
3 years, 4 months ago (2017-07-28 14:41:12 UTC) #29
lazyboy
lgtm
3 years, 4 months ago (2017-07-28 16:31:00 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2980503002/120001
3 years, 4 months ago (2017-07-31 13:44:30 UTC) #35
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/423075)
3 years, 4 months ago (2017-07-31 15:35:20 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2980503002/140001
3 years, 4 months ago (2017-07-31 18:08:31 UTC) #44
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/513817)
3 years, 4 months ago (2017-07-31 20:25:17 UTC) #46
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2980503002/140001
3 years, 4 months ago (2017-08-01 16:47:49 UTC) #48
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/352785)
3 years, 4 months ago (2017-08-01 19:37:58 UTC) #50
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2980503002/140001
3 years, 4 months ago (2017-08-01 20:56:25 UTC) #52
commit-bot: I haz the power
3 years, 4 months ago (2017-08-01 22:47:54 UTC) #55
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/6fa6b15543d5e4ce35ac67c8a8fd...

Powered by Google App Engine
This is Rietveld 408576698