chrome/browser/extensions/activity_log/activity_log_task_runner.h - Issue 2980503002: [Extensions][TaskScheduler] Update ActivityLog for scheduling migration

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/activity_log/activity_log_task_runner.h

Issue 2980503002: [Extensions][TaskScheduler] Update ActivityLog for scheduling migration (Closed)

Patch Set: . Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/extensions/activity_log/activity_log_policy.cc ('k') | chrome/browser/extensions/activity_log/activity_log_task_runner.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_EXTENSIONS_ACTIVITY_LOG_ACTIVITY_LOG_TASK_RUNNER_H_

	6 #define CHROME_BROWSER_EXTENSIONS_ACTIVITY_LOG_ACTIVITY_LOG_TASK_RUNNER_H_

	7

	8 #include "base/memory/ref_counted.h"

	9

	10 namespace base {

	11 class TaskRunner;

	12 }

	13

	14 namespace extensions {

	15

	16 const scoped_refptr<base::TaskRunner> GetActivityLogTaskRunner();

	17

	18 void SetActivityLogTaskRunnerForTesting(base::TaskRunner* task_runner);
	Devlin 2017/07/10 18:48:39 This appears to be needed for activity log unittes This appears to be needed for activity log unittests. Without setting the runner here, the sql database always fails to open with a disk I/O error; other similar areas of the code using sql databases seem to do the same thing in unit testing. I've tried adding a ScopedTaskEnvironment, but no luck. gab@, is this expected/correct? Or should there be a way of running a sql database in a unittest with a constructed task runner? gab 2017/07/12 00:30:22 This is a ChromeRenderViewHostTestHarness which ha Show quoted text On 2017/07/10 18:48:39, Devlin wrote: > This appears to be needed for activity log unittests. Without setting the > runner here, the sql database always fails to open with a disk I/O error; other > similar areas of the code using sql databases seem to do the same thing in unit > testing. I've tried adding a ScopedTaskEnvironment, but no luck. This is a ChromeRenderViewHostTestHarness which has a TestBrowserThreadBundle (which provides a ScopedTaskEnvironment equivalent so you already have a TaskScheduler) Show quoted text > > gab@, is this expected/correct? Or should there be a way of running a sql > database in a unittest with a constructed task runner? This is because the unit tests previously depended on TestBrowserThreadBundle faking the DB thread on the main thread (such that "async" work would execute as part of RunLoop::Run()), now you need to content::RunAllBlockingPoolTasksUntilIdle() instead to flush main thread and async work. Or doing what you did ForTesting is also fine (though IMO not as clean) if you prefer to keep everything on the main thread for the unit test.
	19

	20 } // namespace extensions

	21

	22 #endif // CHROME_BROWSER_EXTENSIONS_ACTIVITY_LOG_ACTIVITY_LOG_TASK_RUNNER_H_

OLD	NEW