Improve comparison of intervals in SVGSMILElement::resolveFirstInterval

Improve comparison of intervals in SVGSMILElement::resolveFirstInterval

For open-ended intervals such as [3) - i.e. begin=3s and end/duration/etc
unspecified - every call to resolveFirstInterval() would think that a new
interval had been created, and notify/require a reschedule of the
animations.
Add a new type SMILInterval and a suitable operator for that, and then
use it to compare the raw values (i.e. if both endpoints are exacly the same.)

BUG=377329
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175122

[pdr., 2014-05-27 22:07:34]

This seems like a good patch. Is it up for review?

[fs, 2014-05-28 07:47:58]

On 2014/05/27 22:07:34, pdr wrote:
> This seems like a good patch. Is it up for review?

It certainly could be =)

[fs, 2014-05-28 07:48:17]

...and now it is.

[pdr., 2014-05-28 21:56:24]

LGTM

https://codereview.chromium.org/298043005/diff/1/Source/core/svg/animation/SM...
File Source/core/svg/animation/SMILTime.h (right):

https://codereview.chromium.org/298043005/diff/1/Source/core/svg/animation/SM...
Source/core/svg/animation/SMILTime.h:107: // Compare the "raw" values since the
operator!= for SMILTime always return
Please file a bug about this. This is crazy:
inline bool operator==(const SMILTime& a, const SMILTime& b) { return
a.isFinite() && a.value() == b.value(); }

[fs, 2014-05-30 08:02:46]

https://codereview.chromium.org/298043005/diff/1/Source/core/svg/animation/SM...
File Source/core/svg/animation/SMILTime.h (right):

https://codereview.chromium.org/298043005/diff/1/Source/core/svg/animation/SM...
Source/core/svg/animation/SMILTime.h:107: // Compare the "raw" values since the
operator!= for SMILTime always return
On 2014/05/28 21:56:24, pdr wrote:
> Please file a bug about this. This is crazy:
> inline bool operator==(const SMILTime& a, const SMILTime& b) { return
> a.isFinite() && a.value() == b.value(); }

I'm not sure it's 100% crazy (maybe 84% crazy) - at least not if you consider
these "non finite" values as NaN or similar. FWIW I've considered just changing
SMILTime::unresolvedValue to NaN and SMILTime::indefiniteValue as Infinity. That
might help (or maybe confuse even more...)

Filed crbug.com/379080

[fs, 2014-05-30 08:03:03]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2014-05-30 08:03:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/fs@opera.com/298043005/1

[commit-bot: I haz the power, 2014-05-30 13:08:48]

Change committed as 175122