Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2168)

Unified Diff: Source/core/svg/animation/SVGSMILElement.cpp

Issue 298043005: Improve comparison of intervals in SVGSMILElement::resolveFirstInterval (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/svg/animation/SVGSMILElement.cpp
diff --git a/Source/core/svg/animation/SVGSMILElement.cpp b/Source/core/svg/animation/SVGSMILElement.cpp
index a97bc50d29b62d72b57d37142800813dfc989bbc..6c217d61391697e430a8ef36eebbd47fee8b3c45 100644
--- a/Source/core/svg/animation/SVGSMILElement.cpp
+++ b/Source/core/svg/animation/SVGSMILElement.cpp
@@ -932,14 +932,13 @@ void SVGSMILElement::resolveInterval(bool first, SMILTime& beginResult, SMILTime
void SVGSMILElement::resolveFirstInterval()
{
- SMILTime begin;
- SMILTime end;
- resolveInterval(true, begin, end);
- ASSERT(!begin.isIndefinite());
+ SMILInterval firstInterval;
+ resolveInterval(true, firstInterval.begin, firstInterval.end);
+ ASSERT(!firstInterval.begin.isIndefinite());
- if (!begin.isUnresolved() && (begin != m_intervalBegin || end != m_intervalEnd)) {
- m_intervalBegin = begin;
- m_intervalEnd = end;
+ if (!firstInterval.begin.isUnresolved() && firstInterval != SMILInterval(m_intervalBegin, m_intervalEnd)) {
+ m_intervalBegin = firstInterval.begin;
+ m_intervalEnd = firstInterval.end;
notifyDependentsIntervalChanged();
m_nextProgressTime = min(m_nextProgressTime, m_intervalBegin);
« Source/core/svg/animation/SMILTime.h ('K') | « Source/core/svg/animation/SMILTime.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698