Improve comparison of intervals in SVGSMILElement::resolveFirstInterval

Source/core/svg/animation/SMILTime.h

 /*
  * Copyright (C) 2008 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 62 matching lines @@
     }
 
     const SMILTime& time() const { return m_time; }
     bool originIsScript() const { return m_origin == ScriptOrigin; }
 
 private:
     SMILTime m_time;
     Origin m_origin;
 };
 
+struct SMILInterval {
+    SMILInterval() { }
+    SMILInterval(const SMILTime& begin, const SMILTime& end) : begin(begin), end(end) { }
+
+    SMILTime begin;
+    SMILTime end;
+};
+
 inline bool operator==(const SMILTime& a, const SMILTime& b) { return a.isFinite() && a.value() == b.value(); }
 inline bool operator!(const SMILTime& a) { return !a.isFinite() || !a.value(); }
 inline bool operator!=(const SMILTime& a, const SMILTime& b) { return !operator==(a, b); }
 inline bool operator>(const SMILTime& a, const SMILTime& b) { return a.value() > b.value(); }
 inline bool operator<(const SMILTime& a, const SMILTime& b) { return a.value() < b.value(); }
 inline bool operator>=(const SMILTime& a, const SMILTime& b) { return a.value() > b.value() || operator==(a, b); }
 inline bool operator<=(const SMILTime& a, const SMILTime& b) { return a.value() < b.value() || operator==(a, b); }
 inline bool operator<(const SMILTimeWithOrigin& a, const SMILTimeWithOrigin& b) { return a.time() < b.time(); }
 
 SMILTime operator+(const SMILTime&, const SMILTime&);
 SMILTime operator-(const SMILTime&, const SMILTime&);
 // So multiplying times does not make too much sense but SMIL defines it for duration * repeatCount
 SMILTime operator*(const SMILTime&, const SMILTime&);
 
+inline bool operator!=(const SMILInterval& a, const SMILInterval& b)
+{
+    // Compare the "raw" values since the operator!= for SMILTime always return

[pdr., 2014/05/28 21:56:24]

Please file a bug about this. This is crazy:
inline bool operator==(const SMILTime& a, const SMILTime& b) { return
a.isFinite() && a.value() == b.value(); }

[fs, 2014/05/30 08:02:47]

I'm not sure it's 100% crazy (maybe 84% crazy) - at least not if you consider
these "non finite" values as NaN or similar. FWIW I've considered just changing
SMILTime::unresolvedValue to NaN and SMILTime::indefiniteValue as Infinity. That
might help (or maybe confuse even more...)

Filed crbug.com/379080

+    // true for non-finite times.
+    return a.begin.value() != b.begin.value() || a.end.value() != b.end.value();
+}
+
 }
 
 #endif // SMILTime_h