Infer network connection type from network interface type.

Infer Windows network connection type from interface type.

If all active network interfaces have the same network
connection type it's safe to assume this is the type of
the network connection.  Make NetworkChangeNotifier return
this network connection type on Windows.

BUG=160537
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278881

[pauljensen, 2014-06-19 03:17:21]

Matt, PTAL.

[mmenke, 2014-06-19 14:53:10]

On 2014/06/19 03:17:21, pauljensen wrote:
> Matt, PTAL.

Maybe make ConnectionTypeFromInterfaces take in an NetworkInterfaceList, and add
a couple unit tests?  Code is simple and certainly looks correct to me, but it's
easy enough to test, and always safest to have a couple tests, even for simple
code.

[pauljensen, 2014-06-20 05:58:53]

Matt, PTAL.

https://codereview.chromium.org/298023005/diff/60001/net/base/network_change_...
File net/base/network_change_notifier.h (right):

https://codereview.chromium.org/298023005/diff/60001/net/base/network_change_...
net/base/network_change_notifier.h:14: #include "net/base/net_export.h"
Sadly I cannot include net_util.h here because it includes
network_change_notifier.h (which is a no-op because of the recursive include
guards) before using NetworkChangeNotifier::ConnectionType.

https://codereview.chromium.org/298023005/diff/60001/net/base/network_change_...
net/base/network_change_notifier.h:24: typedef std::vector<NetworkInterface>
NetworkInterfaceList;
This is sadly necessary because net_util.h includes network_change_notifier.h
before declaring NetworkInterfaceList.

[mmenke, 2014-06-20 15:18:58]

LGTM, just nits.

https://codereview.chromium.org/298023005/diff/60001/net/base/network_change_...
File net/base/network_change_notifier.h (right):

https://codereview.chromium.org/298023005/diff/60001/net/base/network_change_...
net/base/network_change_notifier.h:24: typedef std::vector<NetworkInterface>
NetworkInterfaceList;
On 2014/06/20 05:58:53, pauljensen wrote:
> This is sadly necessary because net_util.h includes network_change_notifier.h
> before declaring NetworkInterfaceList.

Ugly, but fine for now.  I'd argue it may make sense to have
ConnectionTypeFromInterfaceList as a NET_EXPORT_PRIVATE in the same file as
NetworkInterface, but net_util already has enough random stuff as it is.  And
NET_EXPORT_PRIVATE doesn't give us any hard guarantees about non-use externally,
unfortunately.

https://codereview.chromium.org/298023005/diff/90001/net/base/network_change_...
File net/base/network_change_notifier_unittest.cc (right):

https://codereview.chromium.org/298023005/diff/90001/net/base/network_change_...
net/base/network_change_notifier_unittest.cc:4: 
nit:  #include "network_change_notifier.h", one line above the others.

https://codereview.chromium.org/298023005/diff/90001/net/base/network_change_...
net/base/network_change_notifier_unittest.cc:19:
TEST_F(NetworkChangeNotifierTest, InterfacesToConnectionType) {
nit:  Can we get rid of the test fixture, and just use TEST?

https://codereview.chromium.org/298023005/diff/90001/net/base/network_change_...
net/base/network_change_notifier_unittest.cc:50: // Ignore fake teredo
interface.
nit:  I believe Teredo should be capitalized.

https://codereview.chromium.org/298023005/diff/90001/net/base/network_change_...
net/base/network_change_notifier_unittest.cc:55: // Verify we ignore teredo
element type.
nit:  Don't use "we" in comments.

https://codereview.chromium.org/298023005/diff/90001/net/base/network_change_...
net/base/network_change_notifier_unittest.cc:58: // Verify we take type of
non-teredo element.
nit:  Don't use "we" in comments.

[pauljensen, 2014-06-20 19:22:32]

https://codereview.chromium.org/298023005/diff/90001/net/base/network_change_...
File net/base/network_change_notifier_unittest.cc (right):

https://codereview.chromium.org/298023005/diff/90001/net/base/network_change_...
net/base/network_change_notifier_unittest.cc:4: 
On 2014/06/20 15:18:57, mmenke wrote:
> nit:  #include "network_change_notifier.h", one line above the others.

Done.

https://codereview.chromium.org/298023005/diff/90001/net/base/network_change_...
net/base/network_change_notifier_unittest.cc:19:
TEST_F(NetworkChangeNotifierTest, InterfacesToConnectionType) {
On 2014/06/20 15:18:57, mmenke wrote:
> nit:  Can we get rid of the test fixture, and just use TEST?

Done. I forgot you could friend functions.

https://codereview.chromium.org/298023005/diff/90001/net/base/network_change_...
net/base/network_change_notifier_unittest.cc:50: // Ignore fake teredo
interface.
On 2014/06/20 15:18:57, mmenke wrote:
> nit:  I believe Teredo should be capitalized.

Done.

https://codereview.chromium.org/298023005/diff/90001/net/base/network_change_...
net/base/network_change_notifier_unittest.cc:55: // Verify we ignore teredo
element type.
On 2014/06/20 15:18:57, mmenke wrote:
> nit:  Don't use "we" in comments.

Done.

https://codereview.chromium.org/298023005/diff/90001/net/base/network_change_...
net/base/network_change_notifier_unittest.cc:58: // Verify we take type of
non-teredo element.
On 2014/06/20 15:18:57, mmenke wrote:
> nit:  Don't use "we" in comments.

Done.

[pauljensen, 2014-06-20 19:25:10]

The CQ bit was checked by pauljensen@chromium.org

[commit-bot: I haz the power, 2014-06-20 19:27:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pauljensen@chromium.org/298023005/130001

[commit-bot: I haz the power, 2014-06-20 23:50:42]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)

[commit-bot: I haz the power, 2014-06-21 00:46:31]

Change committed as 278881