net/base/network_change_notifier_win.cc - Issue 298023005: Infer network connection type from network interface type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/network_change_notifier_win.cc

Issue 298023005: Infer network connection type from network interface type. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Avoid std::vector operator[] element creation Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/base/network_change_notifier_win.cc

diff --git a/net/base/network_change_notifier_win.cc b/net/base/network_change_notifier_win.cc

index 77a72b0d6934150162ff5b4516c4ac6b8c7f3266..05268d4b6a85bcfe1c803abfe5e659dfc985d571 100644

--- a/net/base/network_change_notifier_win.cc

+++ b/net/base/network_change_notifier_win.cc

@@ -200,8 +200,7 @@ NetworkChangeNotifierWin::RecomputeCurrentConnectionType() const {

LOG_IF(ERROR, result != 0)

<< "WSALookupServiceEnd() failed with: " << result;

- // TODO(droger): Return something more detailed than CONNECTION_UNKNOWN.

- return found_connection ? NetworkChangeNotifier::CONNECTION_UNKNOWN :

+ return found_connection ? ConnectionTypeFromInterfaces() :

NetworkChangeNotifier::CONNECTION_NONE;

}

« no previous file with comments | « net/base/network_change_notifier_unittest.cc ('k') | net/net.gypi » ('j') | no next file with comments »