Infer network connection type from network interface type.

net/base/network_change_notifier_unittest.cc

+// Copyright (c) 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+

[mmenke, 2014/06/20 15:18:57]

nit:  #include "network_change_notifier.h", one line above the others.

[pauljensen, 2014/06/20 19:22:31]

Done.

+#include "net/base/net_util.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace net {
+
+class NetworkChangeNotifierTest : public testing::Test {
+ public:
+  NetworkChangeNotifierTest() {}
+  virtual ~NetworkChangeNotifierTest() {}
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(NetworkChangeNotifierTest);
+};
+
+TEST_F(NetworkChangeNotifierTest, InterfacesToConnectionType) {

[mmenke, 2014/06/20 15:18:57]

nit:  Can we get rid of the test fixture, and just use TEST?

[pauljensen, 2014/06/20 19:22:32]

Done. I forgot you could friend functions.

+  NetworkInterfaceList list;
+
+  // Test empty list.
+  EXPECT_EQ(NetworkChangeNotifier::ConnectionTypeFromInterfaceList(list),
+            NetworkChangeNotifier::CONNECTION_UNKNOWN);
+
+  NetworkInterface interface;
+  for (int i = NetworkChangeNotifier::CONNECTION_UNKNOWN;
+       i < NetworkChangeNotifier::CONNECTION_LAST;
+       i++) {
+    // Check individual types.
+    list.clear();
+    interface.type = static_cast<NetworkChangeNotifier::ConnectionType>(i);
+    list.push_back(interface);
+    EXPECT_EQ(NetworkChangeNotifier::ConnectionTypeFromInterfaceList(list), i);
+    // Check two types.
+    for (int j = NetworkChangeNotifier::CONNECTION_UNKNOWN;
+         j < NetworkChangeNotifier::CONNECTION_LAST;
+         j++) {
+      list.clear();
+      interface.type = static_cast<NetworkChangeNotifier::ConnectionType>(i);
+      list.push_back(interface);
+      interface.type = static_cast<NetworkChangeNotifier::ConnectionType>(j);
+      list.push_back(interface);
+      EXPECT_EQ(NetworkChangeNotifier::ConnectionTypeFromInterfaceList(list),
+                i == j ? i : NetworkChangeNotifier::CONNECTION_UNKNOWN);
+    }
+  }
+
+#if defined(OS_WIN)
+  // Ignore fake teredo interface.

[mmenke, 2014/06/20 15:18:57]

nit:  I believe Teredo should be capitalized.

[pauljensen, 2014/06/20 19:22:32]

Done.

+  list.clear();
+  interface.type = NetworkChangeNotifier::CONNECTION_4G;
+  interface.friendly_name = "Teredo Tunneling Pseudo-Interface";
+  list.push_back(interface);
+  // Verify we ignore teredo element type.

[mmenke, 2014/06/20 15:18:57]

nit:  Don't use "we" in comments.

[pauljensen, 2014/06/20 19:22:32]

Done.

+  EXPECT_EQ(NetworkChangeNotifier::ConnectionTypeFromInterfaceList(list),
+            NetworkChangeNotifier::CONNECTION_UNKNOWN);
+  // Verify we take type of non-teredo element.

[mmenke, 2014/06/20 15:18:57]

nit:  Don't use "we" in comments.

[pauljensen, 2014/06/20 19:22:32]

Done.

+  interface.type = NetworkChangeNotifier::CONNECTION_3G;
+  interface.friendly_name = "";
+  list.push_back(interface);
+  EXPECT_EQ(NetworkChangeNotifier::ConnectionTypeFromInterfaceList(list),
+            NetworkChangeNotifier::CONNECTION_3G);
+  // Reverse elements.
+  list[2] = list[0];
+  list.erase(list.begin());
+  EXPECT_EQ(NetworkChangeNotifier::ConnectionTypeFromInterfaceList(list),
+            NetworkChangeNotifier::CONNECTION_3G);
+#endif
+}
+
+}  // namespace net