Issue 2980023002: GN: Change the default meaning of dart_target_arch from current_cpu to target_cpu.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2980023002: GN: Change the default meaning of dart_target_arch from current_cpu to target_cpu. (Closed)

Created:
3 years, 5 months ago by rmacnak

Modified:
3 years, 5 months ago

Reviewers:
zra

CC:
reviews_dartlang.org, zra, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

GN: Change the default meaning of dart_target_arch from current_cpu to target_cpu. Update args.gn for the simulator builds to compensate. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/be95b916ddf0af2b204286a438e7169e3bb2c67a

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -32 lines)			Patch
M	runtime/BUILD.gn	View	1 2	1 chunk	+20 lines, -26 lines	0 comments	Download
M	runtime/runtime_args.gni	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	tools/gn.py	View		3 chunks	+23 lines, -3 lines	0 comments	Download

Total messages: 5 (2 generated)

rmacnak

3 years, 5 months ago (2017-07-13 21:59:41 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
be95b916ddf0af2b204286a438e7169e3bb2c67a (presubmit successful).