Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: runtime/runtime_args.gni

Issue 2980023002: GN: Change the default meaning of dart_target_arch from current_cpu to target_cpu. (Closed)
Patch Set: gn format Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/BUILD.gn ('k') | tools/gn.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/runtime_args.gni
diff --git a/runtime/runtime_args.gni b/runtime/runtime_args.gni
index d3f4710abf2b729dc31df85520b41cc02fc7fbd9..26213ca98de8161d4d6aceb975c09fb039703a7c 100644
--- a/runtime/runtime_args.gni
+++ b/runtime/runtime_args.gni
@@ -27,10 +27,9 @@ declare_args() {
# dart_debug/dart_product.
dart_runtime_mode = "develop"
- # Explicitly set the target architecture in case of precompilation. Leaving
- # this unspecified results in automatic target architecture detection.
+ # Explicitly set the target architecture to use a simulator.
# Available options are: arm, arm64, x64, ia32, and dbc.
- dart_target_arch = ""
+ dart_target_arch = target_cpu
# The optimization level to use for debug builds.
dart_debug_optimization_level = "2"
« no previous file with comments | « runtime/BUILD.gn ('k') | tools/gn.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698