Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Unified Diff: runtime/BUILD.gn

Issue 2980023002: GN: Change the default meaning of dart_target_arch from current_cpu to target_cpu. (Closed)
Patch Set: gn format Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/runtime_args.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/BUILD.gn
diff --git a/runtime/BUILD.gn b/runtime/BUILD.gn
index 15ce27b25b9ff35a171215dcdb75650f7699fb08..31f925747f7a587fcae34739b169b1930d13a310 100644
--- a/runtime/BUILD.gn
+++ b/runtime/BUILD.gn
@@ -64,32 +64,26 @@ config("dart_config") {
assert(false)
}
- if (dart_target_arch != "") {
- if (dart_target_arch == "arm" || dart_target_arch == "simarm") {
- defines += [ "TARGET_ARCH_ARM" ]
- } else if (dart_target_arch == "armv6" || dart_target_arch == "simarmv6") {
- defines += [ "TARGET_ARCH_ARM" ]
- defines += [ "TARGET_ARCH_ARM_6" ]
- } else if (dart_target_arch == "armv5te" ||
- dart_target_arch == "simarmv5te") {
- defines += [ "TARGET_ARCH_ARM" ]
- defines += [ "TARGET_ARCH_ARM_5TE" ]
- } else if (dart_target_arch == "arm64" || dart_target_arch == "simarm64") {
- defines += [ "TARGET_ARCH_ARM64" ]
- } else if (dart_target_arch == "x64") {
- defines += [ "TARGET_ARCH_X64" ]
- } else if (dart_target_arch == "ia32") {
- defines += [ "TARGET_ARCH_IA32" ]
- } else if (dart_target_arch == "dbc" || dart_target_arch == "simdbc" ||
- dart_target_arch == "simdbc64" ||
- dart_target_arch == "armsimdbc" ||
- dart_target_arch == "armsimdbc64") {
- defines += [ "TARGET_ARCH_DBC" ]
- defines += [ "USING_SIMULATOR" ]
- } else {
- print("Invalid dart_target_arch: $dart_target_arch")
- assert(false)
- }
+ if (dart_target_arch == "arm") {
+ defines += [ "TARGET_ARCH_ARM" ]
+ } else if (dart_target_arch == "armv6") {
+ defines += [ "TARGET_ARCH_ARM" ]
+ defines += [ "TARGET_ARCH_ARM_6" ]
+ } else if (dart_target_arch == "armv5te") {
+ defines += [ "TARGET_ARCH_ARM" ]
+ defines += [ "TARGET_ARCH_ARM_5TE" ]
+ } else if (dart_target_arch == "arm64") {
+ defines += [ "TARGET_ARCH_ARM64" ]
+ } else if (dart_target_arch == "x64") {
+ defines += [ "TARGET_ARCH_X64" ]
+ } else if (dart_target_arch == "ia32" || dart_target_arch == "x86") {
+ defines += [ "TARGET_ARCH_IA32" ]
+ } else if (dart_target_arch == "dbc") {
+ defines += [ "TARGET_ARCH_DBC" ]
+ defines += [ "USING_SIMULATOR" ]
+ } else {
+ print("Invalid dart_target_arch: $dart_target_arch")
+ assert(false)
}
if (dart_debug) {
« no previous file with comments | « no previous file | runtime/runtime_args.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698