Add --set-exit-code-on-problem option.

Add --set-exit-code-on-problem option.

Fixes https://github.com/dart-lang/sdk/issues/30127

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/8a1600b12ed92a7f13e4d54d7285eb51ca7f0ab6

[ahe, 2017-07-11 16:54:13]

ahe@google.com changed reviewers:
+ sigmund@google.com

[ahe, 2017-07-11 16:54:31]

Description was changed from

==========
Add --set-exit-code-on-problem option.
==========

to

==========
Add --set-exit-code-on-problem option.

Fixes https://github.com/dart-lang/sdk/issues/30127
==========

[Siggi Cherem (dart-lang), 2017-07-11 17:04:16]

lgtm

https://codereview.chromium.org/2979713002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/messages.dart (right):

https://codereview.chromium.org/2979713002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/messages.dart:94: if (setExitCodeOnProblem) {
just to make sure, we would practically only get here  when verbose is true,
correct?

[ahe, 2017-07-11 17:52:36]

Thank you, Siggi.

Could you please confirm that it's still lgtm?

https://codereview.chromium.org/2979713002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/messages.dart (right):

https://codereview.chromium.org/2979713002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/messages.dart:94: if (setExitCodeOnProblem) {
On 2017/07/11 17:04:16, Siggi Cherem (dart-lang) wrote:
> just to make sure, we would practically only get here  when verbose is true,
> correct?

No. We get here if we print any diagnostic. But I think that's what we want: the
exit code is set to 1 if we print an error, a warning, or a nit.

[Siggi Cherem (dart-lang), 2017-07-11 18:12:35]

lgtm, thanks for clarifying.

https://codereview.chromium.org/2979713002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/messages.dart (right):

https://codereview.chromium.org/2979713002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/messages.dart:94: if (setExitCodeOnProblem) {
On 2017/07/11 17:52:36, ahe wrote:
> On 2017/07/11 17:04:16, Siggi Cherem (dart-lang) wrote:
> > just to make sure, we would practically only get here  when verbose is true,
> > correct?
> 
> No. We get here if we print any diagnostic. But I think that's what we want:
the
> exit code is set to 1 if we print an error, a warning, or a nit.

OK - so it is done only if something is visible in stdout (I just wanted to make
sure we don't set the exit code and provide no indication of it).

Eventually I'd like to do two changes to this:
 (a) collect all print statements in a single place (since that'll be done only
when there is no listener for messages in the public APIs).
 (b) set the exit code only when we are handling errors ourselves. If someone
wants to handle errors by setting their listener, then they can also handle the
exit code themselves.

I'm OK doing this latter as a follow up, in which case please add a TODO for me
here.

[ahe, 2017-07-12 09:59:06]

Thank you, Siggi!

https://codereview.chromium.org/2979713002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/messages.dart (right):

https://codereview.chromium.org/2979713002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/messages.dart:94: if (setExitCodeOnProblem) {
On 2017/07/11 18:12:34, Siggi Cherem (dart-lang) wrote:
> On 2017/07/11 17:52:36, ahe wrote:
> > On 2017/07/11 17:04:16, Siggi Cherem (dart-lang) wrote:
> > > just to make sure, we would practically only get here  when verbose is
true,
> > > correct?
> > 
> > No. We get here if we print any diagnostic. But I think that's what we want:
> the
> > exit code is set to 1 if we print an error, a warning, or a nit.
> 
> OK - so it is done only if something is visible in stdout (I just wanted to
make
> sure we don't set the exit code and provide no indication of it).
> 
> Eventually I'd like to do two changes to this:
>  (a) collect all print statements in a single place (since that'll be done
only
> when there is no listener for messages in the public APIs).
>  (b) set the exit code only when we are handling errors ourselves. If someone
> wants to handle errors by setting their listener, then they can also handle
the
> exit code themselves.
> 
> I'm OK doing this latter as a follow up, in which case please add a TODO for
me
> here.

I have already implemented this, and should be able to send out a CL for it
later today, so I'll just skip the TODO.

[ahe, 2017-07-12 12:29:23]

Description was changed from

==========
Add --set-exit-code-on-problem option.

Fixes https://github.com/dart-lang/sdk/issues/30127
==========

to

==========
Add --set-exit-code-on-problem option.

Fixes https://github.com/dart-lang/sdk/issues/30127

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8a1600b12ed92a7f13e4d54d7285eb51ca7f0ab6
==========

[ahe, 2017-07-12 12:29:24]

Committed patchset #1 (id:1) manually as
8a1600b12ed92a7f13e4d54d7285eb51ca7f0ab6 (presubmit successful).