Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2982443002: Correctly pass options to CompilerCommandLine.withGlobalOptions. (Closed)

Created:
3 years, 5 months ago by ahe
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, Vyacheslav Egorov (Google), zra
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Correctly pass options to CompilerCommandLine.withGlobalOptions. See #30127. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/42bcc10aa8ffc5392c48782d5e1671840e754bd0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M pkg/front_end/lib/src/kernel_generator_impl.dart View 1 chunk +11 lines, -5 lines 0 comments Download

Dependent Patchsets:

Issue 2979713002 Patch 1

Messages

Total messages: 7 (4 generated)
ahe
3 years, 5 months ago (2017-07-11 16:20:01 UTC) #3
Siggi Cherem (dart-lang)
lgtm thank you
3 years, 5 months ago (2017-07-11 16:46:32 UTC) #5
ahe
3 years, 5 months ago (2017-07-12 10:26:12 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
42bcc10aa8ffc5392c48782d5e1671840e754bd0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698