Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: tools/patch_sdk.dart

Issue 2979713002: Add --set-exit-code-on-problem option. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/patch_sdk.dart
diff --git a/tools/patch_sdk.dart b/tools/patch_sdk.dart
index e5d71883eb25bbe829d9ebe9aa0330aeb95b9ddc..cfc50f2c01f0da61007ee9cad8348de8f011ed8c 100644
--- a/tools/patch_sdk.dart
+++ b/tools/patch_sdk.dart
@@ -143,6 +143,7 @@ Future _main(List<String> argv) async {
var program = await kernelForProgram(
Uri.parse('dart:$vmserviceName'),
new CompilerOptions()
+ ..setExitCodeOnProblem = true
// TODO(sigmund): investigate. This should be outline, but it breaks
// vm-debug tests. Issue #30111
..sdkSummary = platform
@@ -204,6 +205,7 @@ Future _main(List<String> argv) async {
Future<List<Uri>> compilePlatform(Uri patchedSdk, Target target, Uri packages,
Uri fullOutput, Uri outlineOutput) async {
var options = new CompilerOptions()
+ ..setExitCodeOnProblem = true
..strongMode = false
..compileSdk = true
..sdkRoot = patchedSdk
« pkg/front_end/lib/src/fasta/messages.dart ('K') | « pkg/front_end/lib/src/kernel_generator_impl.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698