Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 2979653004: DevTools: clean unused styles in Elements (Closed)

Created:
3 years, 5 months ago by luoe
Modified:
3 years, 5 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: clean unused styles in Elements BUG=none Review-Url: https://codereview.chromium.org/2979653004 Cr-Commit-Position: refs/heads/master@{#486237} Committed: https://chromium.googlesource.com/chromium/src/+/a88be112c22ab93d56a9c169b6a8ce4b3317bbc2

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -87 lines) Patch
M third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/EventListenersWidget.js View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/elementsPanel.css View 2 chunks +0 lines, -84 lines 2 comments Download

Messages

Total messages: 8 (4 generated)
luoe
Please take a look https://codereview.chromium.org/2979653004/diff/1/third_party/WebKit/Source/devtools/front_end/elements/elementsPanel.css File third_party/WebKit/Source/devtools/front_end/elements/elementsPanel.css (left): https://codereview.chromium.org/2979653004/diff/1/third_party/WebKit/Source/devtools/front_end/elements/elementsPanel.css#oldcode99 third_party/WebKit/Source/devtools/front_end/elements/elementsPanel.css:99: .metrics-and-computed { These 2 were ...
3 years, 5 months ago (2017-07-12 20:03:22 UTC) #2
lushnikov
lgtm
3 years, 5 months ago (2017-07-12 20:09:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2979653004/1
3 years, 5 months ago (2017-07-12 20:10:44 UTC) #5
commit-bot: I haz the power
3 years, 5 months ago (2017-07-13 02:53:21 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a88be112c22ab93d56a9c169b6a8...

Powered by Google App Engine
This is Rietveld 408576698