Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2175903002: DevTools: follow-up to view introduction, fix styles css. (Closed)

Created:
4 years, 5 months ago by pfeldman
Modified:
4 years, 5 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: follow-up to view introduction, fix styles css. BUG=630355 NOTRY=true Committed: https://crrev.com/377a9762958c69dba606bfd8dd4b766aad69c9c4 Cr-Commit-Position: refs/heads/master@{#407293}

Patch Set 1 #

Patch Set 2 : lcean #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -12 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/network/network-choose-preview-view-expected.txt View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/elementsPanel.css View 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/SidebarPane.js View 2 chunks +19 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Widget.js View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/sidebarPane.css View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
pfeldman
4 years, 5 months ago (2016-07-22 19:05:30 UTC) #2
lushnikov
thanks, lgtm
4 years, 5 months ago (2016-07-22 20:44:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2175903002/1
4 years, 5 months ago (2016-07-22 20:54:42 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/267771)
4 years, 5 months ago (2016-07-22 22:03:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2175903002/20001
4 years, 5 months ago (2016-07-22 23:10:15 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-22 23:14:03 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 23:15:51 UTC) #15
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/377a9762958c69dba606bfd8dd4b766aad69c9c4
Cr-Commit-Position: refs/heads/master@{#407293}

Powered by Google App Engine
This is Rietveld 408576698