Use Layoutselection::SelectionBounds() in RevealSelection()

Use Layoutselection::SelectionBounds() in RevealSelection()

Before this patch, we use VisibleUnit::ComputeTextRect() to compute
 a rect to scroll.
However, ComputeTextRect() calls InlineTextBox::LocalSelectionRect() which
 depends on InlineTextBox current SelectionState.
To avoid that, update SeletionState and get a rect directly from 
 LayoutSelection::SelectionBounds().


BUG=739062, 740401
TEST=LayoutTests/editing/input/scroll-with-tab-to-input-regression.html

Review-Url: https://codereview.chromium.org/2979513002
Cr-Commit-Position: refs/heads/master@{#485214}
Committed: https://chromium.googlesource.com/chromium/src/+/a6a78b205297ad9733dbe8d828dcc43cfad7667e

[yoichio, 2017-07-10 07:26:11]

The CQ bit was checked by yoichio@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-10 07:26:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yoichio, 2017-07-10 07:46:36]

The CQ bit was checked by yoichio@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-10 07:46:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yoichio, 2017-07-10 07:53:49]

Description was changed from

==========
Layoutselection

BUG=
==========

to

==========
Use Layoutselection::SelectionBounds() in RevealSelection()

Before this patch, we use VisibleUnit::ComputeTextRect() to compute
 a rect to scroll.
However, ComputeTextRect() calls InlineTextBox::LocalSelectionRect() which
 depends on InlineTextBox current SelectionState.
To avoid that, update SeletionState and get a rect directly from 
 LayoutSelection::SelectionBounds().


BUG=739062
TEST=LayoutTests/editing/input/scroll-with-tab-to-input-regression.html
==========

[yoichio, 2017-07-10 07:53:49]

yoichio@chromium.org changed reviewers:
+ yosin@chromium.org

[yoichio, 2017-07-10 08:03:26]

Description was changed from

==========
Use Layoutselection::SelectionBounds() in RevealSelection()

Before this patch, we use VisibleUnit::ComputeTextRect() to compute
 a rect to scroll.
However, ComputeTextRect() calls InlineTextBox::LocalSelectionRect() which
 depends on InlineTextBox current SelectionState.
To avoid that, update SeletionState and get a rect directly from 
 LayoutSelection::SelectionBounds().


BUG=739062
TEST=LayoutTests/editing/input/scroll-with-tab-to-input-regression.html
==========

to

==========
Use Layoutselection::SelectionBounds() in RevealSelection()

Before this patch, we use VisibleUnit::ComputeTextRect() to compute
 a rect to scroll.
However, ComputeTextRect() calls InlineTextBox::LocalSelectionRect() which
 depends on InlineTextBox current SelectionState.
To avoid that, update SeletionState and get a rect directly from 
 LayoutSelection::SelectionBounds().


BUG=739062, 740401
TEST=LayoutTests/editing/input/scroll-with-tab-to-input-regression.html
==========

[yosin_UTC9, 2017-07-10 08:43:31]

The CQ bit was unchecked by yosin@chromium.org

[yosin_UTC9, 2017-07-10 08:43:33]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2017-07-10 08:43:34]

lgtm

[commit-bot: I haz the power, 2017-07-10 08:43:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-10 09:21:42]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1499676213949460,
"parent_rev": "8ab5bc94aa5e440b71521e065a1fb86c584e2e1b", "commit_rev":
"a6a78b205297ad9733dbe8d828dcc43cfad7667e"}

[commit-bot: I haz the power, 2017-07-10 09:21:55]

Description was changed from

==========
Use Layoutselection::SelectionBounds() in RevealSelection()

Before this patch, we use VisibleUnit::ComputeTextRect() to compute
 a rect to scroll.
However, ComputeTextRect() calls InlineTextBox::LocalSelectionRect() which
 depends on InlineTextBox current SelectionState.
To avoid that, update SeletionState and get a rect directly from 
 LayoutSelection::SelectionBounds().


BUG=739062, 740401
TEST=LayoutTests/editing/input/scroll-with-tab-to-input-regression.html
==========

to

==========
Use Layoutselection::SelectionBounds() in RevealSelection()

Before this patch, we use VisibleUnit::ComputeTextRect() to compute
 a rect to scroll.
However, ComputeTextRect() calls InlineTextBox::LocalSelectionRect() which
 depends on InlineTextBox current SelectionState.
To avoid that, update SeletionState and get a rect directly from 
 LayoutSelection::SelectionBounds().


BUG=739062, 740401
TEST=LayoutTests/editing/input/scroll-with-tab-to-input-regression.html

Review-Url: https://codereview.chromium.org/2979513002
Cr-Commit-Position: refs/heads/master@{#485214}
Committed:
https://chromium.googlesource.com/chromium/src/+/a6a78b205297ad9733dbe8d828dc...
==========

[commit-bot: I haz the power, 2017-07-10 09:21:56]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a6a78b205297ad9733dbe8d828dc...