Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: third_party/WebKit/Source/core/editing/FrameSelection.h

Issue 2979513002: Use Layoutselection::SelectionBounds() in RevealSelection() (Closed)
Patch Set: update Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/FrameSelection.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
3 * reserved. 3 * reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 262 matching lines...) Expand 10 before | Expand all | Expand 10 after
273 273
274 void SetUseSecureKeyboardEntry(bool); 274 void SetUseSecureKeyboardEntry(bool);
275 275
276 void UpdateSelectionIfNeeded(const Position& base, 276 void UpdateSelectionIfNeeded(const Position& base,
277 const Position& extent, 277 const Position& extent,
278 const Position& start, 278 const Position& start,
279 const Position& end); 279 const Position& end);
280 280
281 GranularityStrategy* GetGranularityStrategy(); 281 GranularityStrategy* GetGranularityStrategy();
282 282
283 IntRect ComputeRectToScroll(RevealExtentOption);
284
283 // Implementation of |SynchronousMutationObserver| member functions. 285 // Implementation of |SynchronousMutationObserver| member functions.
284 void ContextDestroyed(Document*) final; 286 void ContextDestroyed(Document*) final;
285 void NodeChildrenWillBeRemoved(ContainerNode&) final; 287 void NodeChildrenWillBeRemoved(ContainerNode&) final;
286 void NodeWillBeRemoved(Node&) final; 288 void NodeWillBeRemoved(Node&) final;
287 289
288 Member<LocalFrame> frame_; 290 Member<LocalFrame> frame_;
289 const Member<LayoutSelection> layout_selection_; 291 const Member<LayoutSelection> layout_selection_;
290 const Member<SelectionEditor> selection_editor_; 292 const Member<SelectionEditor> selection_editor_;
291 293
292 TextGranularity granularity_; 294 TextGranularity granularity_;
(...skipping 11 matching lines...) Expand all
304 306
305 } // namespace blink 307 } // namespace blink
306 308
307 #ifndef NDEBUG 309 #ifndef NDEBUG
308 // Outside the WebCore namespace for ease of invocation from gdb. 310 // Outside the WebCore namespace for ease of invocation from gdb.
309 void showTree(const blink::FrameSelection&); 311 void showTree(const blink::FrameSelection&);
310 void showTree(const blink::FrameSelection*); 312 void showTree(const blink::FrameSelection*);
311 #endif 313 #endif
312 314
313 #endif // FrameSelection_h 315 #endif // FrameSelection_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/FrameSelection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698