Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2979503002: Move animation timing tests to subdirectory (Closed)

Created:
3 years, 5 months ago by suzyh_UTC10 (ex-contributor)
Modified:
3 years, 5 months ago
Reviewers:
meade_UTC10
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, mac-reviews_chromium.org, rjwright, shans
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move animation timing tests to subdirectory This patch moves tests related to animation timing (e.g. linear, ease, steps) from LayoutTests/animations to a dedicated subdirectory. BUG=623434 Review-Url: https://codereview.chromium.org/2979503002 Cr-Commit-Position: refs/heads/master@{#485524} Committed: https://chromium.googlesource.com/chromium/src/+/d2c55c215aa2520ab733ab3d6a43887453a00a71

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1450 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG View 2 chunks +2 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/animation-duration-infinite.html View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/animation-duration-infinite-expected.html View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/delay-timer-cancel-bug.html View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/implicit-keyframe-with-timing-function.html View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/keyframe-multiple-timing-functions-transform.html View 1 chunk +0 lines, -48 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/keyframe-multiple-timing-functions-transform-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/keyframe-timing-functions.html View 1 chunk +0 lines, -58 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/keyframe-timing-functions-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/keyframe-timing-functions-multiple-animations.html View 1 chunk +0 lines, -52 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/keyframe-timing-functions-multiple-animations-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/keyframe-timing-functions-transform.html View 1 chunk +0 lines, -62 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/keyframe-timing-functions-transform-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/keyframe-timing-functions2.html View 1 chunk +0 lines, -61 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/keyframe-timing-functions2-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/keyframe-timing-functions3.html View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/keyframe-timing-functions3-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/longhand-timing-function.html View 1 chunk +0 lines, -57 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/longhand-timing-function-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/missing-keyframe-properties-timing-function.html View 1 chunk +0 lines, -77 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/missing-keyframe-properties-timing-function-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/multiple-animations-timing-function.html View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/multiple-animations-timing-function-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/timing-functions.html View 1 chunk +0 lines, -155 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/timing-functions-expected.txt View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/timing-functions-neutral-keyframe.html View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/timing-functions-update-animation.html View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/timing-model.html View 1 chunk +0 lines, -334 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/timing-model-expected.txt View 1 chunk +0 lines, -143 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/timing-properties-update-paused-animation.html View 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/timing-properties-update-running-animation.html View 1 chunk +0 lines, -43 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/timing/animation-duration-infinite.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/timing/animation-duration-infinite-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/timing/delay-timer-cancel-bug.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/timing/implicit-keyframe-with-timing-function.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/timing/keyframe-multiple-timing-functions-transform.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/animations/timing/keyframe-multiple-timing-functions-transform-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/timing/keyframe-timing-functions.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/animations/timing/keyframe-timing-functions-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/timing/keyframe-timing-functions-multiple-animations.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/animations/timing/keyframe-timing-functions-multiple-animations-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/timing/keyframe-timing-functions-transform.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/animations/timing/keyframe-timing-functions-transform-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/timing/keyframe-timing-functions2.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/animations/timing/keyframe-timing-functions2-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/timing/keyframe-timing-functions3.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/animations/timing/keyframe-timing-functions3-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/timing/longhand-timing-function.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/animations/timing/longhand-timing-function-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/timing/missing-keyframe-properties-timing-function.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/animations/timing/missing-keyframe-properties-timing-function-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/timing/multiple-animations-timing-function.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/animations/timing/multiple-animations-timing-function-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/timing/timing-functions.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/animations/timing/timing-functions-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/timing/timing-functions-neutral-keyframe.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/timing/timing-functions-update-animation.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/timing/timing-model.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/timing/timing-model-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/timing/timing-properties-update-paused-animation.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/timing/timing-properties-update-running-animation.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/timing/translate-neutral-keyframe-easing.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/timing/translate-neutral-keyframe-easing-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/translate-neutral-keyframe-easing.html View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/translate-neutral-keyframe-easing-expected.html View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/animations/keyframe-multiple-timing-functions-transform-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/animations/timing/keyframe-multiple-timing-functions-transform-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/animations/keyframe-multiple-timing-functions-transform-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac/animations/timing/keyframe-multiple-timing-functions-transform-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/animations/keyframe-multiple-timing-functions-transform-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/win/animations/timing/keyframe-multiple-timing-functions-transform-expected.png View Binary file 0 comments Download

Depends on Patchset:

Issue 2975723002 Patch 1

Dependent Patchsets:

Issue 2976613002 Patch 1

Messages

Total messages: 12 (8 generated)
suzyh_UTC10 (ex-contributor)
3 years, 5 months ago (2017-07-10 05:48:23 UTC) #2
meade_UTC10
lgtm
3 years, 5 months ago (2017-07-10 08:04:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2979503002/1
3 years, 5 months ago (2017-07-11 04:48:29 UTC) #9
commit-bot: I haz the power
3 years, 5 months ago (2017-07-11 04:54:22 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d2c55c215aa2520ab733ab3d6a43...

Powered by Google App Engine
This is Rietveld 408576698