Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2975723002: Move direction and fill tests to subdirectory (Closed)

Created:
3 years, 5 months ago by suzyh_UTC10 (ex-contributor)
Modified:
3 years, 5 months ago
Reviewers:
Eric Willigers
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move direction and fill tests to subdirectory This patch moves tests related to direction (e.g. reverse, alternate) and fill (e.g. fill forwards, fill backwards) from LayoutTests/animations to a dedicated subdirectory. BUG=623434 Review-Url: https://codereview.chromium.org/2975723002 Cr-Commit-Position: refs/heads/master@{#485522} Committed: https://chromium.googlesource.com/chromium/src/+/edc6df873b3a0acc6772d089a3c34ee44b40fe0d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1900 lines) Patch
M third_party/WebKit/LayoutTests/SlowTests View 2 chunks +4 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/animation-direction-alternate.html View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/animation-direction-alternate-reverse.html View 1 chunk +0 lines, -56 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/animation-direction-normal.html View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/animation-direction-reverse-fill-mode.html View 1 chunk +0 lines, -78 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/animation-direction-reverse-fill-mode-hardware.html View 1 chunk +0 lines, -103 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/animation-direction-reverse-fill-mode-hardware-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/animation-direction-reverse-hardware.html View 1 chunk +0 lines, -99 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/animation-direction-reverse-hardware-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/animation-direction-reverse-hardware-opacity.html View 1 chunk +0 lines, -99 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/animation-direction-reverse-hardware-opacity-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/animation-direction-reverse-non-hardware.html View 1 chunk +0 lines, -118 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/animation-direction-reverse-timing-functions.html View 1 chunk +0 lines, -81 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/animation-direction-reverse-timing-functions-hardware.html View 1 chunk +0 lines, -75 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/animation-direction-reverse-timing-functions-hardware-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/direction-and-fill/animation-direction-alternate.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/direction-and-fill/animation-direction-alternate-reverse.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/direction-and-fill/animation-direction-normal.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/direction-and-fill/animation-direction-reverse-fill-mode.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/direction-and-fill/animation-direction-reverse-fill-mode-hardware.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/animations/direction-and-fill/animation-direction-reverse-fill-mode-hardware-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/direction-and-fill/animation-direction-reverse-hardware.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/animations/direction-and-fill/animation-direction-reverse-hardware-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/direction-and-fill/animation-direction-reverse-hardware-opacity.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/animations/direction-and-fill/animation-direction-reverse-hardware-opacity-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/direction-and-fill/animation-direction-reverse-non-hardware.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/direction-and-fill/animation-direction-reverse-timing-functions.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/direction-and-fill/animation-direction-reverse-timing-functions-hardware.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/animations/direction-and-fill/animation-direction-reverse-timing-functions-hardware-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/direction-and-fill/fill-mode.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/direction-and-fill/fill-mode-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/direction-and-fill/fill-mode-forwards2.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/direction-and-fill/fill-mode-forwards2-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/direction-and-fill/fill-mode-iteration-count-non-integer.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/direction-and-fill/fill-mode-iteration-count-non-integer-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/direction-and-fill/fill-mode-missing-from-to-keyframes.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/direction-and-fill/fill-mode-missing-from-to-keyframes-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/direction-and-fill/fill-mode-multiple-keyframes.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/direction-and-fill/fill-mode-multiple-keyframes-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/direction-and-fill/fill-mode-removed.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/direction-and-fill/fill-mode-removed-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/direction-and-fill/fill-mode-transform.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/direction-and-fill/fill-mode-transform-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/fill-mode.html View 1 chunk +0 lines, -130 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/fill-mode-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/fill-mode-forwards2.html View 1 chunk +0 lines, -54 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/fill-mode-forwards2-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/animations/fill-mode-iteration-count-non-integer.html View 1 chunk +0 lines, -140 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/fill-mode-iteration-count-non-integer-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/fill-mode-missing-from-to-keyframes.html View 1 chunk +0 lines, -194 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/fill-mode-missing-from-to-keyframes-expected.txt View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/fill-mode-multiple-keyframes.html View 1 chunk +0 lines, -169 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/fill-mode-multiple-keyframes-expected.txt View 1 chunk +0 lines, -32 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/fill-mode-removed.html View 1 chunk +0 lines, -110 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/fill-mode-removed-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/fill-mode-transform.html View 1 chunk +0 lines, -133 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/fill-mode-transform-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download

Depends on Patchset:

Issue 2976603002 Patch 1

Dependent Patchsets:

Issue 2979503002 Patch 1

Messages

Total messages: 12 (8 generated)
suzyh_UTC10 (ex-contributor)
3 years, 5 months ago (2017-07-10 05:48:02 UTC) #2
Eric Willigers
lgtm
3 years, 5 months ago (2017-07-10 12:56:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2975723002/1
3 years, 5 months ago (2017-07-11 04:41:37 UTC) #9
commit-bot: I haz the power
3 years, 5 months ago (2017-07-11 04:47:14 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/edc6df873b3a0acc6772d089a3c3...

Powered by Google App Engine
This is Rietveld 408576698