Add manifest links and hack to index on revision.

Add manifest links and hack to index on revision.

R=hinoka@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2979283002
Committed: https://github.com/luci/luci-go/commit/4b08c484b7714d5e89a889e023aa8ec256dbd2f0

[iannucci, 2017-07-19 00:21:11]

The CQ bit was checked by iannucci@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-19 00:21:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-19 00:27:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-19 00:27:05]

Dry run: This issue passed the CQ dry run.

[Ryan Tseng, 2017-07-19 00:29:38]

hinoka@google.com changed reviewers:
+ hinoka@google.com

[Ryan Tseng, 2017-07-19 00:29:39]

https://codereview.chromium.org/2979283002/diff/1/common/proto/milo/annotatio...
File common/proto/milo/annotations.proto (right):

https://codereview.chromium.org/2979283002/diff/1/common/proto/milo/annotatio...
common/proto/milo/annotations.proto:148: // The hash of the Manifest. Milo will
use this as an optimization;
"The hash of the content of the Manifest in binary proto form"?

https://codereview.chromium.org/2979283002/diff/1/milo/api/resp/build.go
File milo/api/resp/build.go (right):

https://codereview.chromium.org/2979283002/diff/1/milo/api/resp/build.go#newc...
milo/api/resp/build.go:301: logging.WithError(err).Warningf(c, "bad revision
(not hex-decodable)")
return here, forgo the else.

https://codereview.chromium.org/2979283002/diff/1/milo/api/resp/build.go#newc...
milo/api/resp/build.go:307: projs, err := common.GetAllProjects(c)
just make a common.GetConsolesForBuilder(c)

[iannucci, 2017-07-19 00:38:12]

The CQ bit was checked by iannucci@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-19 00:38:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[iannucci, 2017-07-19 00:38:16]

https://codereview.chromium.org/2979283002/diff/1/common/proto/milo/annotatio...
File common/proto/milo/annotations.proto (right):

https://codereview.chromium.org/2979283002/diff/1/common/proto/milo/annotatio...
common/proto/milo/annotations.proto:148: // The hash of the Manifest. Milo will
use this as an optimization;
On 2017/07/19 00:29:38, Ryan Tseng wrote:
> "The hash of the content of the Manifest in binary proto form"?

Done.

https://codereview.chromium.org/2979283002/diff/1/milo/api/resp/build.go
File milo/api/resp/build.go (right):

https://codereview.chromium.org/2979283002/diff/1/milo/api/resp/build.go#newc...
milo/api/resp/build.go:301: logging.WithError(err).Warningf(c, "bad revision
(not hex-decodable)")
On 2017/07/19 00:29:38, Ryan Tseng wrote:
> return here, forgo the else.

no, I actually want the rest of the function here I think

https://codereview.chromium.org/2979283002/diff/1/milo/api/resp/build.go#newc...
milo/api/resp/build.go:307: projs, err := common.GetAllProjects(c)
On 2017/07/19 00:29:38, Ryan Tseng wrote:
> just make a common.GetConsolesForBuilder(c)

Done.

[Ryan Tseng, 2017-07-19 00:45:56]

lgtm

https://codereview.chromium.org/2979283002/diff/1/milo/api/resp/build.go
File milo/api/resp/build.go (right):

https://codereview.chromium.org/2979283002/diff/1/milo/api/resp/build.go#newc...
milo/api/resp/build.go:301: logging.WithError(err).Warningf(c, "bad revision
(not hex-decodable)")
On 2017/07/19 00:38:16, iannucci wrote:
> On 2017/07/19 00:29:38, Ryan Tseng wrote:
> > return here, forgo the else.
> 
> no, I actually want the rest of the function here I think

oh merp i forgot the stuff before ::wishes there was a way to "continue" to the
end of an if block::

https://codereview.chromium.org/2979283002/diff/20001/milo/api/resp/build.go
File milo/api/resp/build.go (right):

https://codereview.chromium.org/2979283002/diff/20001/milo/api/resp/build.go#...
milo/api/resp/build.go:311: for _, cons := range consoles {
nit: cons -> con (pretty sure this is singular)

[commit-bot: I haz the power, 2017-07-19 00:47:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-19 00:47:46]

Dry run: This issue passed the CQ dry run.

[iannucci, 2017-07-19 01:20:43]

https://codereview.chromium.org/2979283002/diff/20001/milo/api/resp/build.go
File milo/api/resp/build.go (right):

https://codereview.chromium.org/2979283002/diff/20001/milo/api/resp/build.go#...
milo/api/resp/build.go:311: for _, cons := range consoles {
On 2017/07/19 00:45:56, Ryan Tseng wrote:
> nit: cons -> con (pretty sure this is singular)

Done.

[iannucci, 2017-07-19 01:20:47]

The CQ bit was checked by iannucci@chromium.org

[commit-bot: I haz the power, 2017-07-19 01:20:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[iannucci, 2017-07-19 01:21:08]

The CQ bit was unchecked by iannucci@chromium.org

[iannucci, 2017-07-19 01:21:37]

The CQ bit was checked by iannucci@chromium.org to run a CQ dry run

[iannucci, 2017-07-19 01:21:40]

The CQ bit was checked by iannucci@chromium.org

[iannucci, 2017-07-19 01:21:40]

The patchset sent to the CQ was uploaded after l-g-t-m from hinoka@google.com
Link to the patchset: https://codereview.chromium.org/2979283002/#ps40001
(title: "actually upload")

[commit-bot: I haz the power, 2017-07-19 01:21:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-19 01:27:37]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1500427300417100,
"parent_rev": "746d72c63ab1f6cd0911794ffba1ce8dc60f4f8f", "commit_rev":
"4b08c484b7714d5e89a889e023aa8ec256dbd2f0"}

[commit-bot: I haz the power, 2017-07-19 01:27:41]

Description was changed from

==========
Add manifest links and hack to index on revision.

R=hinoka@chromium.org
BUG=
==========

to

==========
Add manifest links and hack to index on revision.

R=hinoka@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2979283002
Committed:
https://github.com/luci/luci-go/commit/4b08c484b7714d5e89a889e023aa8ec256dbd2f0
==========

[commit-bot: I haz the power, 2017-07-19 01:27:42]

Committed patchset #3 (id:40001) as
https://github.com/luci/luci-go/commit/4b08c484b7714d5e89a889e023aa8ec256dbd2f0