Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: milo/buildsource/buildbot/pubsub.go

Issue 2979283002: Add manifest links and hack to index on revision. (Closed)
Patch Set: actually upload Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « milo/api/resp/build.go ('k') | milo/buildsource/buildbucket/pubsub.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/buildsource/buildbot/pubsub.go
diff --git a/milo/buildsource/buildbot/pubsub.go b/milo/buildsource/buildbot/pubsub.go
index 714e43b217ff921ece33e3d8c108d59e89084cab..b82e3f812695584df40ec41c1e611291dfbf9250 100644
--- a/milo/buildsource/buildbot/pubsub.go
+++ b/milo/buildsource/buildbot/pubsub.go
@@ -233,7 +233,9 @@ func saveBuildSummary(c context.Context, b *buildbotBuild) error {
BuildKey: datastore.KeyForObj(c, b),
BuilderID: fmt.Sprintf("buildbot/%s/%s", b.Master, b.Buildername),
}
- resp.SummarizeTo(&bs)
+ if err := resp.SummarizeTo(c, &bs); err != nil {
+ return err
+ }
return datastore.Put(c, &bs)
}
« no previous file with comments | « milo/api/resp/build.go ('k') | milo/buildsource/buildbucket/pubsub.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698