Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 2978873002: Singletons changes necessary to run the UI Service inside the browser's process. (Closed)

Created:
3 years, 5 months ago by mfomitchev
Modified:
3 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

The changes are as follows: 1. InputDeviceManager becomes a thread-local singleton instead of a global singleton. UI Service instantiates DeviceDataManager, which is the service- side implementation of InputDeviceManager, while the browser uses InputDeviceClient, which is the client-side implementation. 2. PlatformEventSource also becomes a thread-local singleton. This is to prevent ash and the browser from executing code on the UI Service's thread by registering PlatformEventObservers (e.g. via UserActivityDetector). In the futurer we may need a client-side implementation of PlatformEventSource. 3. GPU Service checks if a PowerMonitor singleton exists before creating one. This is temporary until GPU Service runs in a separate process from the UI Service. (crbug.com/609317). BUG=722527 Review-Url: https://codereview.chromium.org/2978873002 Cr-Commit-Position: refs/heads/master@{#486534} Committed: https://chromium.googlesource.com/chromium/src/+/f76cad2a7e88da1ddc5a7a2df053cee1c4f3c02f

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Removing unneeded dependency. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -21 lines) Patch
M services/ui/gpu/gpu_main.h View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/gpu/gpu_main.cc View 1 chunk +8 lines, -1 line 0 comments Download
M ui/events/devices/input_device_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/events/devices/input_device_manager.cc View 1 chunk +17 lines, -7 lines 0 comments Download
M ui/events/platform/platform_event_source.h View 3 chunks +2 lines, -2 lines 0 comments Download
M ui/events/platform/platform_event_source.cc View 1 chunk +19 lines, -7 lines 0 comments Download

Messages

Total messages: 25 (19 generated)
mfomitchev
PTAL: In-process Mus Part 2.
3 years, 5 months ago (2017-07-13 02:34:46 UTC) #4
sky
LGTM
3 years, 5 months ago (2017-07-13 17:15:47 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2978873002/40001
3 years, 5 months ago (2017-07-13 18:55:57 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/220324)
3 years, 5 months ago (2017-07-13 20:56:00 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2978873002/40001
3 years, 5 months ago (2017-07-13 21:12:25 UTC) #20
commit-bot: I haz the power
3 years, 5 months ago (2017-07-13 23:33:27 UTC) #25
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f76cad2a7e88da1ddc5a7a2df053...

Powered by Google App Engine
This is Rietveld 408576698