Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2977763002: config_service: Changed lists from paper-items to paper-cards, fixed (Closed)

Created:
3 years, 5 months ago by cwpayton
Modified:
3 years, 5 months ago
Reviewers:
Sergey Berezin, hinoka
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

config_service: Changed lists from paper-items to paper-cards, fixed search box, added shadows and slight animation. BUG=730832 Review-Url: https://codereview.chromium.org/2977763002 Committed: https://github.com/luci/luci-py/commit/4d627a522380d34a18e57b534fa38f4180e418c3

Patch Set 1 #

Patch Set 2 : Forgot to take out https://luci-config.appspot.com from iron-ajax requests for localhost use. #

Patch Set 3 : Added tests, rebased a few functions to bind the "this" object to them instead of a new variable. #

Patch Set 4 : Fixed formatting nit. #

Total comments: 1

Patch Set 5 : Fixed nit regarding first letter of sentence in comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+269 lines, -132 lines) Patch
M appengine/config_service/ui/bower.json View 2 chunks +4 lines, -2 lines 0 comments Download
M appengine/config_service/ui/common/auth-signin.html View 1 2 3 2 chunks +7 lines, -17 lines 0 comments Download
M appengine/config_service/ui/common/third_party/google-signin/google-signin-aware.html View 1 2 1 chunk +4 lines, -5 lines 0 comments Download
M appengine/config_service/ui/src/config-ui/config-file-card.html View 2 chunks +26 lines, -26 lines 0 comments Download
M appengine/config_service/ui/src/config-ui/config-set.html View 1 6 chunks +25 lines, -10 lines 0 comments Download
M appengine/config_service/ui/src/config-ui/config-set-card.html View 2 chunks +49 lines, -28 lines 0 comments Download
M appengine/config_service/ui/src/config-ui/config-ui.html View 1 chunk +4 lines, -12 lines 0 comments Download
M appengine/config_service/ui/src/config-ui/front-page.html View 1 2 3 4 6 chunks +42 lines, -17 lines 0 comments Download
M appengine/config_service/ui/test/config-ui/config-set_test.html View 1 2 8 chunks +95 lines, -8 lines 0 comments Download
M appengine/config_service/ui/test/config-ui/front-page_test.html View 1 2 3 chunks +13 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
cwpayton
PTAL
3 years, 5 months ago (2017-07-12 18:28:10 UTC) #2
cwpayton
Staging version can be found here: https://2956-56121b3-tainted-cwpayton-dot-luci-config.appspot.com/newui#/
3 years, 5 months ago (2017-07-12 18:28:41 UTC) #3
Sergey Berezin
LGTM + a couple of nits. In the CL description, please link to the more ...
3 years, 5 months ago (2017-07-13 02:59:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2977763002/80001
3 years, 5 months ago (2017-07-13 03:34:38 UTC) #7
commit-bot: I haz the power
3 years, 5 months ago (2017-07-13 03:37:17 UTC) #10
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://github.com/luci/luci-py/commit/4d627a522380d34a18e57b534fa38f4180e418c3

Powered by Google App Engine
This is Rietveld 408576698