appengine/config_service/ui/common/third_party/google-signin/google-signin-aware.html - Issue 2977763002: config_service: Changed lists from paper-items to paper-cards, fixed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/config_service/ui/common/third_party/google-signin/google-signin-aware.html

Issue 2977763002: config_service: Changed lists from paper-items to paper-cards, fixed (Closed)

Patch Set: Fixed nit regarding first letter of sentence in comment. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « appengine/config_service/ui/common/auth-signin.html ('k') | appengine/config_service/ui/src/config-ui/config-file-card.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/config_service/ui/common/third_party/google-signin/google-signin-aware.html

diff --git a/appengine/config_service/ui/common/third_party/google-signin/google-signin-aware.html b/appengine/config_service/ui/common/third_party/google-signin/google-signin-aware.html

index 4368b2951ff1de04b15fd5ca85c604ff5b85e284..03f21163c6fc1ec5b8d489d1df08888ad387e616 100644

--- a/appengine/config_service/ui/common/third_party/google-signin/google-signin-aware.html

+++ b/appengine/config_service/ui/common/third_party/google-signin/google-signin-aware.html

@@ -230,14 +230,13 @@ limitations under the License.

signinAwares: [],

init: function() {

- var that = this;

document.addEventListener('DOMContentLoaded', function() {

- that._apiLoader = document.createElement('google-js-api');

- that._apiLoader.addEventListener('js-api-load', that.loadAuth2.bind(that));

+ this._apiLoader = document.createElement('google-js-api');

+ this._apiLoader.addEventListener('js-api-load', this.loadAuth2.bind(this));

if (Polymer.Element) {

- document.body.appendChild(that._apiLoader);

+ document.body.appendChild(this._apiLoader);

}

- })

+ }.bind(this));

loadAuth2: function() {