Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2977693002: Remove deprecated methods from ClassBuilder. (Closed)

Created:
3 years, 5 months ago by ahe
Modified:
3 years, 5 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, dart-uxr+reviews_google.com, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Spelling of unnamed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+562 lines, -90 lines) Patch
M pkg/analyzer/test/generated/parser_fasta_test.dart View 2 chunks +7 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/class_builder.dart View 1 chunk +0 lines, -9 lines 0 comments Download
M pkg/front_end/lib/src/fasta/fasta_codes_generated.dart View 1 6 chunks +385 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart View 4 chunks +39 lines, -31 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart View 1 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart View 2 chunks +7 lines, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_class_builder.dart View 3 chunks +22 lines, -10 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_loader.dart View 6 chunks +40 lines, -34 lines 0 comments Download
M pkg/front_end/messages.yaml View 1 1 chunk +54 lines, -0 lines 0 comments Download
M pkg/front_end/tool/_fasta/generate_messages.dart View 1 chunk +5 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (2 generated)
ahe
3 years, 5 months ago (2017-07-11 15:16:58 UTC) #2
Johnni Winther
lgtm https://codereview.chromium.org/2977693002/diff/1/pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart File pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart (right): https://codereview.chromium.org/2977693002/diff/1/pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart#newcode264 pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart:264: addCompileTimeError(messageNoUnamedConstructorInObject, -1); messageNoUnamedConstructorInObject -> messageNoUnnamedConstructorInObject
3 years, 5 months ago (2017-07-11 18:57:57 UTC) #3
ahe
Thank you, Johnni! https://codereview.chromium.org/2977693002/diff/1/pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart File pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart (right): https://codereview.chromium.org/2977693002/diff/1/pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart#newcode264 pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart:264: addCompileTimeError(messageNoUnamedConstructorInObject, -1); On 2017/07/11 18:57:57, Johnni ...
3 years, 5 months ago (2017-07-12 19:34:46 UTC) #4
ahe
3 years, 5 months ago (2017-07-12 19:59:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
59e963823299d78233e189989fc5e9746e5e4e71 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698