Remove deprecated methods from ClassBuilder.

pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library fasta.kernel_class_builder;
 
 import 'package:kernel/ast.dart'
     show
         Class,
         Constructor,
         DartType,
         Expression,
         Field,
         FunctionNode,
         InterfaceType,
         ListLiteral,
         Member,
         Name,
         Procedure,
         ProcedureKind,
         StaticGet,
         Supertype,
         VariableDeclaration;
 
 import 'package:kernel/class_hierarchy.dart' show ClassHierarchy;
 
 import '../dill/dill_member_builder.dart' show DillMemberBuilder;
 
-import '../fasta_codes.dart' show templateRedirectionTargetNotFound;
+import '../fasta_codes.dart'
+    show
+        templateOverrideFewerNamedArguments,
+        templateOverrideFewerPositionalArguments,
+        templateOverrideMismatchNamedParameter,
+        templateOverrideMoreRequiredArguments,
+        templateOverrideTypeVariablesMismatch,
+        templateRedirectionTargetNotFound;
 
 import '../problems.dart' show unhandled, unimplemented;
 
 import 'kernel_builder.dart'
     show
         Builder,
         ClassBuilder,
         ConstructorReferenceBuilder,
         KernelLibraryBuilder,
         KernelProcedureBuilder,
@@ skipping 186 matching lines @@
       // TODO(ahe): Include these checks as well, but the message needs to
       // explain that [declaredMember] is inherited.
       return;
     }
     assert(declaredMember.kind == ProcedureKind.Method);
     assert(interfaceMember.kind == ProcedureKind.Method);
     FunctionNode declaredFunction = declaredMember.function;
     FunctionNode interfaceFunction = interfaceMember.function;
     if (declaredFunction.typeParameters?.length !=
         interfaceFunction.typeParameters?.length) {
-      deprecated_addWarning(
-          declaredMember.fileOffset,
-          "Declared type variables of '$name::${declaredMember.name.name}' "
-          "doesn't match those on overridden method "
-          "'${interfaceMember.enclosingClass.name}::"
-          "${interfaceMember.name.name}'.");
+      addWarning(
+          templateOverrideTypeVariablesMismatch.withArguments(
+              "$name::${declaredMember.name.name}",
+              "${interfaceMember.enclosingClass.name}::"
+              "${interfaceMember.name.name}"),
+          declaredMember.fileOffset);
     }
     if (declaredFunction.positionalParameters.length <
             interfaceFunction.requiredParameterCount ||
         declaredFunction.positionalParameters.length <
             interfaceFunction.positionalParameters.length) {
-      deprecated_addWarning(
-          declaredMember.fileOffset,
-          "The method '$name::${declaredMember.name.name}' has fewer "
-          "positional arguments than those of overridden method "
-          "'${interfaceMember.enclosingClass.name}::"
-          "${interfaceMember.name.name}'.");
+      addWarning(
+          templateOverrideFewerPositionalArguments.withArguments(
+              "$name::${declaredMember.name.name}",
+              "${interfaceMember.enclosingClass.name}::"
+              "${interfaceMember.name.name}"),
+          declaredMember.fileOffset);
     }
     if (interfaceFunction.requiredParameterCount <
         declaredFunction.requiredParameterCount) {
-      deprecated_addWarning(
-          declaredMember.fileOffset,
-          "The method '$name::${declaredMember.name.name}' has more "
-          "required arguments than those of overridden method "
-          "'${interfaceMember.enclosingClass.name}::"
-          "${interfaceMember.name.name}'.");
+      addWarning(
+          templateOverrideMoreRequiredArguments.withArguments(
+              "$name::${declaredMember.name.name}",
+              "${interfaceMember.enclosingClass.name}::"
+              "${interfaceMember.name.name}"),
+          declaredMember.fileOffset);
     }
     if (declaredFunction.namedParameters.isEmpty &&
         interfaceFunction.namedParameters.isEmpty) {
       return;
     }
     if (declaredFunction.namedParameters.length <
         interfaceFunction.namedParameters.length) {
-      deprecated_addWarning(
-          declaredMember.fileOffset,
-          "The method '$name::${declaredMember.name.name}' has fewer named "
-          "arguments than those of overridden method "
-          "'${interfaceMember.enclosingClass.name}::"
-          "${interfaceMember.name.name}'.");
+      addWarning(
+          templateOverrideFewerNamedArguments.withArguments(
+              "$name::${declaredMember.name.name}",
+              "${interfaceMember.enclosingClass.name}::"
+              "${interfaceMember.name.name}"),
+          declaredMember.fileOffset);
     }
     Iterator<VariableDeclaration> declaredNamedParameters =
         declaredFunction.namedParameters.iterator;
     Iterator<VariableDeclaration> interfaceNamedParameters =
         interfaceFunction.namedParameters.iterator;
     outer:
     while (declaredNamedParameters.moveNext() &&
         interfaceNamedParameters.moveNext()) {
       while (declaredNamedParameters.current.name !=
           interfaceNamedParameters.current.name) {
         if (!declaredNamedParameters.moveNext()) {
-          deprecated_addWarning(
-              declaredMember.fileOffset,
-              "The method '$name::${declaredMember.name.name}' doesn't have "
-              "the named parameter '${interfaceNamedParameters.current.name}' "
-              "of overriden method '${interfaceMember.enclosingClass.name}::"
-              "${interfaceMember.name.name}'.");
+          addWarning(
+              templateOverrideMismatchNamedParameter.withArguments(
+                  "$name::${declaredMember.name.name}",
+                  interfaceNamedParameters.current.name,
+                  "${interfaceMember.enclosingClass.name}::"
+                  "${interfaceMember.name.name}"),
+              declaredMember.fileOffset);
           break outer;
         }
       }
     }
   }
 
   String get fullNameForErrors {
     return isMixinApplication
         ? "${supertype.fullNameForErrors} with ${mixedInType.fullNameForErrors}"
         : name;
   }
 }