Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 2976753002: Remove deprecated_addNit. (Closed)

Created:
3 years, 5 months ago by ahe
Modified:
3 years, 5 months ago
Reviewers:
Johnni Winther, sra1
CC:
reviews_dartlang.org, dart-uxr+reviews_google.com, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -59 lines) Patch
M pkg/front_end/lib/src/fasta/builder/class_builder.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/library_builder.dart View 2 chunks +0 lines, -9 lines 0 comments Download
M pkg/front_end/lib/src/fasta/fasta_codes_generated.dart View 4 chunks +148 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart View 2 chunks +7 lines, -5 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_invalid_type_builder.dart View 2 chunks +5 lines, -6 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart View 3 chunks +22 lines, -22 lines 0 comments Download
M pkg/front_end/lib/src/fasta/messages.dart View 1 chunk +0 lines, -10 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/stack_listener.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/messages.yaml View 1 chunk +18 lines, -0 lines 2 comments Download
M pkg/front_end/tool/_fasta/generate_messages.dart View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
ahe
3 years, 5 months ago (2017-07-11 13:41:17 UTC) #2
Johnni Winther
lgtm
3 years, 5 months ago (2017-07-11 18:38:15 UTC) #3
sra1
https://codereview.chromium.org/2976753002/diff/1/pkg/front_end/messages.yaml File pkg/front_end/messages.yaml (right): https://codereview.chromium.org/2976753002/diff/1/pkg/front_end/messages.yaml#newcode634 pkg/front_end/messages.yaml:634: ImportHidesImport: Why do we warn about this? It is ...
3 years, 5 months ago (2017-07-11 19:27:44 UTC) #5
ahe
Thank you! https://codereview.chromium.org/2976753002/diff/1/pkg/front_end/messages.yaml File pkg/front_end/messages.yaml (right): https://codereview.chromium.org/2976753002/diff/1/pkg/front_end/messages.yaml#newcode634 pkg/front_end/messages.yaml:634: ImportHidesImport: On 2017/07/11 19:27:44, sra1 wrote: > ...
3 years, 5 months ago (2017-07-12 15:48:17 UTC) #6
ahe
3 years, 5 months ago (2017-07-12 16:44:59 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ca4ad3e65dd6a5f20fe1e76ab93bc05ee55b52b2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698