[wasm] Allow full u32 range for table maximum in WebAssembly.Table constructor.

[wasm] Allow full u32 range for table maximum in WebAssembly.Table constructor.

R=clemensh@chromium.org
BUG=chromium:740199
Review-Url: https://codereview.chromium.org/2977543002
Cr-Commit-Position: refs/heads/master@{#46508}
Committed: https://chromium.googlesource.com/v8/v8/+/0c22df6555ef48e097af8d0fd7cba55664b01bf3

[titzer, 2017-07-10 09:45:19]

The CQ bit was checked by titzer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-10 09:45:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-10 09:48:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-10 09:48:58]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)

[titzer, 2017-07-10 09:53:38]

The CQ bit was checked by titzer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-10 09:53:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-10 10:27:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-10 10:27:19]

Dry run: Try jobs failed on following builders:
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/28743)
  v8_linux_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng_triggered/b...)

[titzer, 2017-07-10 10:31:51]

The CQ bit was checked by titzer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-10 10:31:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Clemens Hammacher, 2017-07-10 10:35:49]

LGTM with nits

https://codereview.chromium.org/2977543002/diff/1/src/wasm/module-compiler.cc
File src/wasm/module-compiler.cc (right):

https://codereview.chromium.org/2977543002/diff/1/src/wasm/module-compiler.cc...
src/wasm/module-compiler.cc:1342: int64_t imported_max_size =
static_cast<int64_t>(
You don't need this static_cast.

https://codereview.chromium.org/2977543002/diff/1/src/wasm/wasm-js.cc
File src/wasm/wasm-js.cc (right):

https://codereview.chromium.org/2977543002/diff/1/src/wasm/wasm-js.cc#newcode642
src/wasm/wasm-js.cc:642:
static_cast<int64_t>(receiver->maximum_length()->Number());
Another redundant static_cast.

[titzer, 2017-07-10 10:37:52]

The CQ bit was checked by titzer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-10 10:37:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[titzer, 2017-07-10 10:38:24]

https://codereview.chromium.org/2977543002/diff/1/src/wasm/module-compiler.cc
File src/wasm/module-compiler.cc (right):

https://codereview.chromium.org/2977543002/diff/1/src/wasm/module-compiler.cc...
src/wasm/module-compiler.cc:1342: int64_t imported_max_size =
static_cast<int64_t>(
On 2017/07/10 10:35:48, Clemens Hammacher wrote:
> You don't need this static_cast.

Done.

https://codereview.chromium.org/2977543002/diff/1/src/wasm/wasm-js.cc
File src/wasm/wasm-js.cc (right):

https://codereview.chromium.org/2977543002/diff/1/src/wasm/wasm-js.cc#newcode642
src/wasm/wasm-js.cc:642:
static_cast<int64_t>(receiver->maximum_length()->Number());
On 2017/07/10 10:35:48, Clemens Hammacher wrote:
> Another redundant static_cast.

Done.

[commit-bot: I haz the power, 2017-07-10 11:03:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-10 11:03:49]

Dry run: This issue passed the CQ dry run.

[titzer, 2017-07-10 11:16:53]

The CQ bit was checked by titzer@chromium.org

[titzer, 2017-07-10 11:16:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
clemensh@chromium.org
Link to the patchset: https://codereview.chromium.org/2977543002/#ps60001
(title: "[wasm] Allow full u32 range for table maximum in WebAssembly.Table
constructor.")

[commit-bot: I haz the power, 2017-07-10 11:17:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-10 11:18:45]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1499685413382960,
"parent_rev": "b14de85dd97d741ed45f5141e996d35542a05458", "commit_rev":
"0c22df6555ef48e097af8d0fd7cba55664b01bf3"}

[commit-bot: I haz the power, 2017-07-10 11:18:52]

Description was changed from

==========
[wasm] Allow full u32 range for table maximum in WebAssembly.Table constructor.

R=clemensh@chromium.org
BUG=chromium:740199
==========

to

==========
[wasm] Allow full u32 range for table maximum in WebAssembly.Table constructor.

R=clemensh@chromium.org
BUG=chromium:740199

Review-Url: https://codereview.chromium.org/2977543002
Cr-Commit-Position: refs/heads/master@{#46508}
Committed:
https://chromium.googlesource.com/v8/v8/+/0c22df6555ef48e097af8d0fd7cba55664b...
==========

[commit-bot: I haz the power, 2017-07-10 11:18:53]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/0c22df6555ef48e097af8d0fd7cba55664b...