src/wasm/module-compiler.cc - Issue 2977543002: [wasm] Allow full u32 range for table maximum in WebAssembly.Table constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/wasm/module-compiler.cc

Issue 2977543002: [wasm] Allow full u32 range for table maximum in WebAssembly.Table constructor. (Closed)

Patch Set: [wasm] Allow full u32 range for table maximum in WebAssembly.Table constructor. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/wasm/module-compiler.cc

diff --git a/src/wasm/module-compiler.cc b/src/wasm/module-compiler.cc

index 3a988e69962eb31e3e9ddd5b1ea144ce1a654b35..16fefa16100179e18281d623a4a5e57822f5b8ee 100644

--- a/src/wasm/module-compiler.cc

+++ b/src/wasm/module-compiler.cc

@@ -1340,7 +1340,7 @@ int InstanceBuilder::ProcessImports(Handle<FixedArray> code_table,

if (table.has_max) {

int64_t imported_max_size =

- table_instance.table_object->maximum_length();

+ table_instance.table_object->maximum_length()->Number();

if (imported_max_size < 0) {

thrower_->LinkError(

"table import %d has no maximum length, expected %d", index,

« no previous file with comments | « no previous file | src/wasm/wasm-js.cc » ('j') | no next file with comments »