DescriptionRevert of [LayoutNG] Set InlineBoxWrapper when copying fragments to LayoutBox (patchset #3 id:40001 of https://codereview.chromium.org/2975663002/ )
Reason for revert:
WebKit layout bots all started failing after this commit.
webkit_tests webkit_tests
Total tests: 66971
* Passed: 56304 (56144 expected, 160 unexpected)
* Skipped: 9131 (9131 expected, 0 unexpected)
* Failed: 1447 (1446 expected, >>>1 unexpected<<<)
* Flaky: 89 (89 expected, 0 unexpected)
Unexpected Failures:
* virtual/layout_ng/fast/block/float/rubybase-children-moved-crash.html
Original issue's description:
> [LayoutNG] Set InlineBoxWrapper when copying fragments to LayoutBox
>
> This patch fixes to set InlineBoxWrapper when copying fragments to
> LayoutBox.
>
> To create InlineBox'es, NGInlineNode::CopyFragmentDataToLayoutBox()
> calls LayoutBlockFlow::ConstructLine(), but it does not set
> InlineBoxWrapper.
>
> LayoutBlockFlow::ComputeBlockDirectionPositionsForLine() sets
> InlineBoxWrapper but LayoutNG does not call this function. It does
> several other things, but SetInlineBoxWrapper() is the only thing needed
> for CopyFragmentDataToLayoutBox().
>
> BUG=636993, 739365
>
> Review-Url: https://codereview.chromium.org/2975663002
> Cr-Commit-Position: refs/heads/master@{#485142}
> Committed: https://chromium.googlesource.com/chromium/src/+/981fa39e2dde70f5933ea2db88123582ab955632
TBR=eae@chromium.org,ikilpatrick@chromium.org,kojii@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=636993, 739365
Review-Url: https://codereview.chromium.org/2977483002
Cr-Commit-Position: refs/heads/master@{#485155}
Committed: https://chromium.googlesource.com/chromium/src/+/991ca91413b8a5694d8d0f83dbb47b9bab336397
Patch Set 1 #
Messages
Total messages: 8 (3 generated)
|