Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2977483002: Revert of [LayoutNG] Set InlineBoxWrapper when copying fragments to LayoutBox (Closed)

Created:
3 years, 5 months ago by Avi (use Gerrit)
Modified:
3 years, 5 months ago
Reviewers:
ikilpatrick, kojii, eae
CC:
atotic+reviews_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, cbiesinger, chromium-reviews, dgrogan+ng_chromium.org, eae+blinkwatch, glebl+reviews_chromium.org, jchaffraix+rendering, lchoi+reviews_chromium.org, leviw+renderwatch, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [LayoutNG] Set InlineBoxWrapper when copying fragments to LayoutBox (patchset #3 id:40001 of https://codereview.chromium.org/2975663002/ ) Reason for revert: WebKit layout bots all started failing after this commit. webkit_tests webkit_tests Total tests: 66971 * Passed: 56304 (56144 expected, 160 unexpected) * Skipped: 9131 (9131 expected, 0 unexpected) * Failed: 1447 (1446 expected, >>>1 unexpected<<<) * Flaky: 89 (89 expected, 0 unexpected) Unexpected Failures: * virtual/layout_ng/fast/block/float/rubybase-children-moved-crash.html Original issue's description: > [LayoutNG] Set InlineBoxWrapper when copying fragments to LayoutBox > > This patch fixes to set InlineBoxWrapper when copying fragments to > LayoutBox. > > To create InlineBox'es, NGInlineNode::CopyFragmentDataToLayoutBox() > calls LayoutBlockFlow::ConstructLine(), but it does not set > InlineBoxWrapper. > > LayoutBlockFlow::ComputeBlockDirectionPositionsForLine() sets > InlineBoxWrapper but LayoutNG does not call this function. It does > several other things, but SetInlineBoxWrapper() is the only thing needed > for CopyFragmentDataToLayoutBox(). > > BUG=636993, 739365 > > Review-Url: https://codereview.chromium.org/2975663002 > Cr-Commit-Position: refs/heads/master@{#485142} > Committed: https://chromium.googlesource.com/chromium/src/+/981fa39e2dde70f5933ea2db88123582ab955632 TBR=eae@chromium.org,ikilpatrick@chromium.org,kojii@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=636993, 739365 Review-Url: https://codereview.chromium.org/2977483002 Cr-Commit-Position: refs/heads/master@{#485155} Committed: https://chromium.googlesource.com/chromium/src/+/991ca91413b8a5694d8d0f83dbb47b9bab336397

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node.cc View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Avi (use Gerrit)
Created Revert of [LayoutNG] Set InlineBoxWrapper when copying fragments to LayoutBox
3 years, 5 months ago (2017-07-09 01:27:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2977483002/1
3 years, 5 months ago (2017-07-09 01:27:47 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/991ca91413b8a5694d8d0f83dbb47b9bab336397
3 years, 5 months ago (2017-07-09 01:28:23 UTC) #6
kojii
lgtm, thank you.
3 years, 5 months ago (2017-07-09 02:55:59 UTC) #7
eae
3 years, 5 months ago (2017-07-10 16:23:20 UTC) #8
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698