|
|
Created:
3 years, 5 months ago by kojii Modified:
3 years, 5 months ago CC:
atotic+reviews_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, cbiesinger, chromium-reviews, dgrogan+ng_chromium.org, eae+blinkwatch, glebl+reviews_chromium.org, jchaffraix+rendering, lchoi+reviews_chromium.org, leviw+renderwatch, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1 Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[LayoutNG] Set InlineBoxWrapper when copying fragments to LayoutBox
Re-land of r485142 due to one crash turned to flaky.
This patch fixes to set InlineBoxWrapper when copying fragments to
LayoutBox.
To create InlineBox'es, NGInlineNode::CopyFragmentDataToLayoutBox()
calls LayoutBlockFlow::ConstructLine(), but it does not set
InlineBoxWrapper.
LayoutBlockFlow::ComputeBlockDirectionPositionsForLine() sets
InlineBoxWrapper but LayoutNG does not call this function. It does
several other things, but SetInlineBoxWrapper() is the only thing needed
for CopyFragmentDataToLayoutBox().
BUG=636993, 739365
Review-Url: https://codereview.chromium.org/2975663002
Cr-Commit-Position: refs/heads/master@{#485160}
Committed: https://chromium.googlesource.com/chromium/src/+/b0ad7c5c03efbe8f725f85201c834389bf6a5b12
Patch Set 1 #Patch Set 2 #Patch Set 3 : TestExpectations #Patch Set 4 : TestExpectations #
Messages
Total messages: 38 (30 generated)
Description was changed from ========== uaf BUG= ========== to ========== uaf BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng ==========
The CQ bit was checked by kojii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by kojii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== uaf BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng ========== to ========== [LayoutNG] Set InlineBoxWrapper when copying fragments to LayoutBox This patch fixes to set InlineBoxWrapper when copying fragments to LayoutBox. NGInlineNode::CopyFragmentDataToLayoutBox calls LayoutBlockFlow::ConstructLine(), but it does not set InlineBoxWrapper. LayoutBlockFlow::ComputeBlockDirectionPositionsForLine() sets InlineBoxWrapper but LayoutNG does not call this function. BUG=636993, 739365 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng ==========
Description was changed from ========== [LayoutNG] Set InlineBoxWrapper when copying fragments to LayoutBox This patch fixes to set InlineBoxWrapper when copying fragments to LayoutBox. NGInlineNode::CopyFragmentDataToLayoutBox calls LayoutBlockFlow::ConstructLine(), but it does not set InlineBoxWrapper. LayoutBlockFlow::ComputeBlockDirectionPositionsForLine() sets InlineBoxWrapper but LayoutNG does not call this function. BUG=636993, 739365 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng ========== to ========== [LayoutNG] Set InlineBoxWrapper when copying fragments to LayoutBox This patch fixes to set InlineBoxWrapper when copying fragments to LayoutBox. To create InlineBox'es, NGInlineNode::CopyFragmentDataToLayoutBox calls LayoutBlockFlow::ConstructLine(), but it does not set InlineBoxWrapper. LayoutBlockFlow::ComputeBlockDirectionPositionsForLine() sets InlineBoxWrapper but LayoutNG does not call this function. BUG=636993, 739365 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng ==========
Description was changed from ========== [LayoutNG] Set InlineBoxWrapper when copying fragments to LayoutBox This patch fixes to set InlineBoxWrapper when copying fragments to LayoutBox. To create InlineBox'es, NGInlineNode::CopyFragmentDataToLayoutBox calls LayoutBlockFlow::ConstructLine(), but it does not set InlineBoxWrapper. LayoutBlockFlow::ComputeBlockDirectionPositionsForLine() sets InlineBoxWrapper but LayoutNG does not call this function. BUG=636993, 739365 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng ========== to ========== [LayoutNG] Set InlineBoxWrapper when copying fragments to LayoutBox This patch fixes to set InlineBoxWrapper when copying fragments to LayoutBox. To create InlineBox'es, NGInlineNode::CopyFragmentDataToLayoutBox() calls LayoutBlockFlow::ConstructLine(), but it does not set InlineBoxWrapper. LayoutBlockFlow::ComputeBlockDirectionPositionsForLine() sets InlineBoxWrapper but LayoutNG does not call this function. It does several other things, but SetInlineBoxWrapper() is the only thing needed for CopyFragmentDataToLayoutBox(). BUG=636993, 739365 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng ==========
kojii@chromium.org changed reviewers: + eae@chromium.org
PTAL. Hopefully this code doesn't live long ;)
ikilpatrick@chromium.org changed reviewers: + ikilpatrick@chromium.org
lgtm
LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_layout_tests_layout_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)
The CQ bit was checked by kojii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_layout_tests_layout_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)
Description was changed from ========== [LayoutNG] Set InlineBoxWrapper when copying fragments to LayoutBox This patch fixes to set InlineBoxWrapper when copying fragments to LayoutBox. To create InlineBox'es, NGInlineNode::CopyFragmentDataToLayoutBox() calls LayoutBlockFlow::ConstructLine(), but it does not set InlineBoxWrapper. LayoutBlockFlow::ComputeBlockDirectionPositionsForLine() sets InlineBoxWrapper but LayoutNG does not call this function. It does several other things, but SetInlineBoxWrapper() is the only thing needed for CopyFragmentDataToLayoutBox(). BUG=636993, 739365 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng ========== to ========== [LayoutNG] Set InlineBoxWrapper when copying fragments to LayoutBox This patch fixes to set InlineBoxWrapper when copying fragments to LayoutBox. To create InlineBox'es, NGInlineNode::CopyFragmentDataToLayoutBox() calls LayoutBlockFlow::ConstructLine(), but it does not set InlineBoxWrapper. LayoutBlockFlow::ComputeBlockDirectionPositionsForLine() sets InlineBoxWrapper but LayoutNG does not call this function. It does several other things, but SetInlineBoxWrapper() is the only thing needed for CopyFragmentDataToLayoutBox(). BUG=636993, 739365 ==========
The CQ bit was checked by kojii@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ikilpatrick@chromium.org, eae@chromium.org Link to the patchset: https://codereview.chromium.org/2975663002/#ps40001 (title: "TestExpectations")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 40001, "attempt_start_ts": 1499500582868350, "parent_rev": "cc07e7e569107ddd6bc833b995c4e7f39691d0f4", "commit_rev": "981fa39e2dde70f5933ea2db88123582ab955632"}
Message was sent while issue was closed.
Description was changed from ========== [LayoutNG] Set InlineBoxWrapper when copying fragments to LayoutBox This patch fixes to set InlineBoxWrapper when copying fragments to LayoutBox. To create InlineBox'es, NGInlineNode::CopyFragmentDataToLayoutBox() calls LayoutBlockFlow::ConstructLine(), but it does not set InlineBoxWrapper. LayoutBlockFlow::ComputeBlockDirectionPositionsForLine() sets InlineBoxWrapper but LayoutNG does not call this function. It does several other things, but SetInlineBoxWrapper() is the only thing needed for CopyFragmentDataToLayoutBox(). BUG=636993, 739365 ========== to ========== [LayoutNG] Set InlineBoxWrapper when copying fragments to LayoutBox This patch fixes to set InlineBoxWrapper when copying fragments to LayoutBox. To create InlineBox'es, NGInlineNode::CopyFragmentDataToLayoutBox() calls LayoutBlockFlow::ConstructLine(), but it does not set InlineBoxWrapper. LayoutBlockFlow::ComputeBlockDirectionPositionsForLine() sets InlineBoxWrapper but LayoutNG does not call this function. It does several other things, but SetInlineBoxWrapper() is the only thing needed for CopyFragmentDataToLayoutBox(). BUG=636993, 739365 Review-Url: https://codereview.chromium.org/2975663002 Cr-Commit-Position: refs/heads/master@{#485142} Committed: https://chromium.googlesource.com/chromium/src/+/981fa39e2dde70f5933ea2db8812... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/981fa39e2dde70f5933ea2db8812...
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2977483002/ by avi@chromium.org. The reason for reverting is: WebKit layout bots all started failing after this commit. webkit_tests webkit_tests Total tests: 66971 * Passed: 56304 (56144 expected, 160 unexpected) * Skipped: 9131 (9131 expected, 0 unexpected) * Failed: 1447 (1446 expected, >>>1 unexpected<<<) * Flaky: 89 (89 expected, 0 unexpected) Unexpected Failures: * virtual/layout_ng/fast/block/float/rubybase-children-moved-crash.html .
The CQ bit was checked by kojii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [LayoutNG] Set InlineBoxWrapper when copying fragments to LayoutBox This patch fixes to set InlineBoxWrapper when copying fragments to LayoutBox. To create InlineBox'es, NGInlineNode::CopyFragmentDataToLayoutBox() calls LayoutBlockFlow::ConstructLine(), but it does not set InlineBoxWrapper. LayoutBlockFlow::ComputeBlockDirectionPositionsForLine() sets InlineBoxWrapper but LayoutNG does not call this function. It does several other things, but SetInlineBoxWrapper() is the only thing needed for CopyFragmentDataToLayoutBox(). BUG=636993, 739365 Review-Url: https://codereview.chromium.org/2975663002 Cr-Commit-Position: refs/heads/master@{#485142} Committed: https://chromium.googlesource.com/chromium/src/+/981fa39e2dde70f5933ea2db8812... ========== to ========== [LayoutNG] Set InlineBoxWrapper when copying fragments to LayoutBox Re-land of r485142 due to one crash turned to flaky. This patch fixes to set InlineBoxWrapper when copying fragments to LayoutBox. To create InlineBox'es, NGInlineNode::CopyFragmentDataToLayoutBox() calls LayoutBlockFlow::ConstructLine(), but it does not set InlineBoxWrapper. LayoutBlockFlow::ComputeBlockDirectionPositionsForLine() sets InlineBoxWrapper but LayoutNG does not call this function. It does several other things, but SetInlineBoxWrapper() is the only thing needed for CopyFragmentDataToLayoutBox(). BUG=636993, 739365 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by kojii@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ikilpatrick@chromium.org, eae@chromium.org Link to the patchset: https://codereview.chromium.org/2975663002/#ps50001 (title: "TestExpectations")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 50001, "attempt_start_ts": 1499622194910480, "parent_rev": "7fa78bb0faf51233cdb427da404134b95e2e87bd", "commit_rev": "b0ad7c5c03efbe8f725f85201c834389bf6a5b12"}
Message was sent while issue was closed.
Description was changed from ========== [LayoutNG] Set InlineBoxWrapper when copying fragments to LayoutBox Re-land of r485142 due to one crash turned to flaky. This patch fixes to set InlineBoxWrapper when copying fragments to LayoutBox. To create InlineBox'es, NGInlineNode::CopyFragmentDataToLayoutBox() calls LayoutBlockFlow::ConstructLine(), but it does not set InlineBoxWrapper. LayoutBlockFlow::ComputeBlockDirectionPositionsForLine() sets InlineBoxWrapper but LayoutNG does not call this function. It does several other things, but SetInlineBoxWrapper() is the only thing needed for CopyFragmentDataToLayoutBox(). BUG=636993, 739365 ========== to ========== [LayoutNG] Set InlineBoxWrapper when copying fragments to LayoutBox Re-land of r485142 due to one crash turned to flaky. This patch fixes to set InlineBoxWrapper when copying fragments to LayoutBox. To create InlineBox'es, NGInlineNode::CopyFragmentDataToLayoutBox() calls LayoutBlockFlow::ConstructLine(), but it does not set InlineBoxWrapper. LayoutBlockFlow::ComputeBlockDirectionPositionsForLine() sets InlineBoxWrapper but LayoutNG does not call this function. It does several other things, but SetInlineBoxWrapper() is the only thing needed for CopyFragmentDataToLayoutBox(). BUG=636993, 739365 Review-Url: https://codereview.chromium.org/2975663002 Cr-Commit-Position: refs/heads/master@{#485160} Committed: https://chromium.googlesource.com/chromium/src/+/b0ad7c5c03efbe8f725f85201c83... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:50001) as https://chromium.googlesource.com/chromium/src/+/b0ad7c5c03efbe8f725f85201c83... |