Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2975663002: [LayoutNG] Set InlineBoxWrapper when copying fragments to LayoutBox (Closed)

Created:
3 years, 5 months ago by kojii
Modified:
3 years, 5 months ago
Reviewers:
ikilpatrick, eae
CC:
atotic+reviews_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, cbiesinger, chromium-reviews, dgrogan+ng_chromium.org, eae+blinkwatch, glebl+reviews_chromium.org, jchaffraix+rendering, lchoi+reviews_chromium.org, leviw+renderwatch, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Set InlineBoxWrapper when copying fragments to LayoutBox Re-land of r485142 due to one crash turned to flaky. This patch fixes to set InlineBoxWrapper when copying fragments to LayoutBox. To create InlineBox'es, NGInlineNode::CopyFragmentDataToLayoutBox() calls LayoutBlockFlow::ConstructLine(), but it does not set InlineBoxWrapper. LayoutBlockFlow::ComputeBlockDirectionPositionsForLine() sets InlineBoxWrapper but LayoutNG does not call this function. It does several other things, but SetInlineBoxWrapper() is the only thing needed for CopyFragmentDataToLayoutBox(). BUG=636993, 739365 Review-Url: https://codereview.chromium.org/2975663002 Cr-Commit-Position: refs/heads/master@{#485160} Committed: https://chromium.googlesource.com/chromium/src/+/b0ad7c5c03efbe8f725f85201c834389bf6a5b12

Patch Set 1 #

Patch Set 2 #

Patch Set 3 : TestExpectations #

Patch Set 4 : TestExpectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node.cc View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 38 (30 generated)
kojii
PTAL. Hopefully this code doesn't live long ;)
3 years, 5 months ago (2017-07-07 18:19:01 UTC) #10
ikilpatrick
lgtm
3 years, 5 months ago (2017-07-07 18:21:10 UTC) #12
eae
LGTM
3 years, 5 months ago (2017-07-07 18:37:38 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2975663002/40001
3 years, 5 months ago (2017-07-08 07:56:29 UTC) #23
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/981fa39e2dde70f5933ea2db88123582ab955632
3 years, 5 months ago (2017-07-08 08:02:13 UTC) #26
Avi (use Gerrit)
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2977483002/ by avi@chromium.org. ...
3 years, 5 months ago (2017-07-09 01:27:39 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2975663002/50001
3 years, 5 months ago (2017-07-09 17:43:26 UTC) #35
commit-bot: I haz the power
3 years, 5 months ago (2017-07-09 17:48:09 UTC) #38
Message was sent while issue was closed.
Committed patchset #4 (id:50001) as
https://chromium.googlesource.com/chromium/src/+/b0ad7c5c03efbe8f725f85201c83...

Powered by Google App Engine
This is Rietveld 408576698