Using GURL in place of std::string for destination_url

content/renderer/pepper/content_decryptor_delegate.cc

Index: content/renderer/pepper/content_decryptor_delegate.cc
diff --git a/content/renderer/pepper/content_decryptor_delegate.cc b/content/renderer/pepper/content_decryptor_delegate.cc
index a36cf6f353965d041c421e3f538bd81c708c6b0b..37803f33c35b74eba8147f7df3c15bcef630df0e 100644
--- a/content/renderer/pepper/content_decryptor_delegate.cc
+++ b/content/renderer/pepper/content_decryptor_delegate.cc
@@ -609,7 +609,8 @@ void ContentDecryptorDelegate::OnSessionMessage(uint32 session_id,
     return;
   }
 
-  session_message_cb_.Run(session_id, message, default_url_string->value());
+  session_message_cb_.Run(
+      session_id, message, GURL(default_url_string->value()));

[xhwang, 2014/05/21 16:59:01]

hmm, the |default_url_string| may not be a valid URL. Maybe we should do the
same check as we do in BrowserMediaPlayerManager, i.e. if

!destination_url.is_valid() && !destination_url.is_empty()

we spit a WARNING and then use an empty GURL.

+ddorwin to confirm this.

[ddorwin, 2014/05/21 17:51:56]

Link:
https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/me...
Doing the same thing here seems fine and is consistent. The other case is more
important because we're passing it across an IPC. Note that we still need to
perform the same checks closer to Blink so that we can cause the event attribute
to be null (and in case another path somehow missed this check).

"Implementations may validate and/or normalize the URL, which could result in a
value that is different from the original or null."
 -
https://dvcs.w3.org/hg/html-media/raw-file/default/encrypted-media/encrypted-...

 }
 
 void ContentDecryptorDelegate::OnSessionReady(uint32 session_id) {