Using GURL in place of std::string for destination_url

content/renderer/pepper/content_decryptor_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/pepper/content_decryptor_delegate.h"
 
 #include "base/callback_helpers.h"
 #include "base/debug/trace_event.h"
 #include "base/message_loop/message_loop_proxy.h"
 #include "base/numerics/safe_conversions.h"
@@ skipping 591 matching lines @@
     message.assign(data, data + message_array_buffer->ByteLength());
   }
 
   StringVar* default_url_string = StringVar::FromPPVar(default_url_var);
 
   if (!default_url_string) {
     OnSessionError(session_id, media::MediaKeys::kUnknownError, 0);
     return;
   }
 
-  session_message_cb_.Run(session_id, message, default_url_string->value());
+  session_message_cb_.Run(
+      session_id, message, GURL(default_url_string->value()));

[xhwang, 2014/05/21 16:59:01]

hmm, the |default_url_string| may not be a valid URL. Maybe we should do the
same check as we do in BrowserMediaPlayerManager, i.e. if

!destination_url.is_valid() && !destination_url.is_empty()

we spit a WARNING and then use an empty GURL.

+ddorwin to confirm this.

[ddorwin, 2014/05/21 17:51:56]

Link:
https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/me...
Doing the same thing here seems fine and is consistent. The other case is more
important because we're passing it across an IPC. Note that we still need to
perform the same checks closer to Blink so that we can cause the event attribute
to be null (and in case another path somehow missed this check).

"Implementations may validate and/or normalize the URL, which could result in a
value that is different from the original or null."
 -
https://dvcs.w3.org/hg/html-media/raw-file/default/encrypted-media/encrypted-...

 }
 
 void ContentDecryptorDelegate::OnSessionReady(uint32 session_id) {
   if (session_ready_cb_.is_null())
     return;
 
   session_ready_cb_.Run(session_id);
 }
 
 void ContentDecryptorDelegate::OnSessionClosed(uint32 session_id) {
@@ skipping 433 matching lines @@
     const media::Decryptor::AudioBuffers empty_frames;
     audio_decode_cb_.ResetAndReturn().Run(media::Decryptor::kError,
                                           empty_frames);
   }
 
   if (!video_decode_cb_.is_null())
     video_decode_cb_.ResetAndReturn().Run(media::Decryptor::kError, NULL);
 }
 
 }  // namespace content