Using GURL in place of std::string for destination_url

content/browser/media/android/browser_media_player_manager.cc

Index: content/browser/media/android/browser_media_player_manager.cc
diff --git a/content/browser/media/android/browser_media_player_manager.cc b/content/browser/media/android/browser_media_player_manager.cc
index ac37e4261fc9466daad23b098db620b086e9ad89..536c70f3268822935d45f13e1ff8d4262c08ba4d 100644
--- a/content/browser/media/android/browser_media_player_manager.cc
+++ b/content/browser/media/android/browser_media_player_manager.cc
@@ -391,16 +391,17 @@ void BrowserMediaPlayerManager::OnSessionMessage(
     int cdm_id,
     uint32 session_id,
     const std::vector<uint8>& message,
-    const std::string& destination_url) {
-  GURL destination_gurl(destination_url);
-  if (!destination_gurl.is_valid() && !destination_gurl.is_empty()) {
+    const GURL& destination_url) {
+  if (!destination_url.is_valid() && !destination_url.is_empty()) {
     DLOG(WARNING) << "SessionMessage destination_url is invalid : "
-                  << destination_gurl.possibly_invalid_spec();
-    destination_gurl = GURL::EmptyGURL();  // Replace invalid destination_url.
+                  << destination_url.possibly_invalid_spec();
+    Send(new CdmMsg_SessionMessage(
+        routing_id(), cdm_id, session_id, message, GURL::EmptyGURL()));

[xhwang, 2014/05/21 16:59:01]

You could still use a "verified_gurl" so that you only need to have one place to
call Send(), which IMHO is a bit cleaner...

[amogh.bihani, 2014/05/22 11:59:49]

I have made the change. I did this as I was thinking about saving some memory by
not introducing a varaible.

+    return;
   }
 
   Send(new CdmMsg_SessionMessage(
-      routing_id(), cdm_id, session_id, message, destination_gurl));
+      routing_id(), cdm_id, session_id, message, destination_url));
 }
 
 void BrowserMediaPlayerManager::OnSessionReady(int cdm_id, uint32 session_id) {