Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 2976783002: Disable drag and drop when we use stylus on Windows (Closed)

Created:
3 years, 5 months ago by lanwei
Modified:
3 years, 5 months ago
Reviewers:
CC:
chromium-reviews, blink-reviews, dtapuska+blinkwatch_chromium.org, Navid Zolghadr
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Disable drag and drop when we use stylus on Windows Windows DoDragDrop function does not support invoking drag and drop support when we handle touch or pen input. If we want to support drag and drop for pen input, we have to listen to WM_MOUSE instead of WM_POINTER. https://msdn.microsoft.com/en-us/library/windows/desktop/ms678486(v=vs.85).aspx Edge does not support drag and drop for pen neither. BUG=724836 TBR=dtapuska@chromium.org Review-Url: https://codereview.chromium.org/2911413002 Cr-Original-Commit-Position: refs/heads/master@{#475934} (cherry picked from commit 984c0003a871be8eec92691961ae0617fe728fb1) Review-Url: https://codereview.chromium.org/2976783002 . Cr-Commit-Position: refs/branch-heads/3112@{#586} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/ac6e8af1c459e9a34d028cc286992b7ca5b90bc7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M third_party/WebKit/Source/core/input/MouseEventManager.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2976783002/1
3 years, 5 months ago (2017-07-11 20:30:31 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 5 months ago (2017-07-11 20:30:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2976783002/1
3 years, 5 months ago (2017-07-11 20:41:16 UTC) #7
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 5 months ago (2017-07-11 20:41:21 UTC) #9
lanwei
3 years, 5 months ago (2017-07-11 20:42:06 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ac6e8af1c459e9a34d028cc286992b7ca5b90bc7 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698