Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2911413002:
Disable drag and drop when we use stylus on Windows (Closed)
DescriptionDisable drag and drop when we use stylus on Windows
Windows DoDragDrop function does not support invoking drag and drop support when
we handle touch or pen input. If we want to support drag and drop for pen input,
we have to listen to WM_MOUSE instead of WM_POINTER.
https://msdn.microsoft.com/en-us/library/windows/desktop/ms678486(v=vs.85).aspx
Edge does not support drag and drop for pen neither.
BUG=724836
Review-Url: https://codereview.chromium.org/2911413002
Cr-Commit-Position: refs/heads/master@{#475934}
Committed: https://chromium.googlesource.com/chromium/src/+/984c0003a871be8eec92691961ae0617fe728fb1
Patch Set 1 #
Messages
Total messages: 19 (12 generated)
The CQ bit was checked by lanwei@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== disable drag drop BUG= ========== to ========== Disable drag and drop when we use stylus on Windows Windows DoDragDrop function does not support invoking drag and drop support when we handle touch or pen input. If we want to support drag and drop for pen input, we have to listen to WM_MOUSE instead of WM_POINTER. Edge does not support drag and drop for pen neither. BUG=24836 ==========
lanwei@chromium.org changed reviewers: + dtapuska@chromium.org
Description was changed from ========== Disable drag and drop when we use stylus on Windows Windows DoDragDrop function does not support invoking drag and drop support when we handle touch or pen input. If we want to support drag and drop for pen input, we have to listen to WM_MOUSE instead of WM_POINTER. Edge does not support drag and drop for pen neither. BUG=24836 ========== to ========== Disable drag and drop when we use stylus on Windows Windows DoDragDrop function does not support invoking drag and drop support when we handle touch or pen input. If we want to support drag and drop for pen input, we have to listen to WM_MOUSE instead of WM_POINTER. Edge does not support drag and drop for pen neither. BUG=24836 ==========
Description was changed from ========== Disable drag and drop when we use stylus on Windows Windows DoDragDrop function does not support invoking drag and drop support when we handle touch or pen input. If we want to support drag and drop for pen input, we have to listen to WM_MOUSE instead of WM_POINTER. Edge does not support drag and drop for pen neither. BUG=24836 ========== to ========== Disable drag and drop when we use stylus on Windows Windows DoDragDrop function does not support invoking drag and drop support when we handle touch or pen input. If we want to support drag and drop for pen input, we have to listen to WM_MOUSE instead of WM_POINTER. https://msdn.microsoft.com/en-us/library/windows/desktop/ms678486(v=vs.85).aspx Edge does not support drag and drop for pen neither. BUG=24836 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/05/31 12:53:50, lanwei wrote: BUG id seems wrong
On 2017/05/31 13:12:12, dtapuska wrote: > On 2017/05/31 12:53:50, lanwei wrote: > > BUG id seems wrong this seems to make sense as we want to convert stylus dragging into direct manipulation like touch to match other operating systems like Android/ChromeOS.
Description was changed from ========== Disable drag and drop when we use stylus on Windows Windows DoDragDrop function does not support invoking drag and drop support when we handle touch or pen input. If we want to support drag and drop for pen input, we have to listen to WM_MOUSE instead of WM_POINTER. https://msdn.microsoft.com/en-us/library/windows/desktop/ms678486(v=vs.85).aspx Edge does not support drag and drop for pen neither. BUG=24836 ========== to ========== Disable drag and drop when we use stylus on Windows Windows DoDragDrop function does not support invoking drag and drop support when we handle touch or pen input. If we want to support drag and drop for pen input, we have to listen to WM_MOUSE instead of WM_POINTER. https://msdn.microsoft.com/en-us/library/windows/desktop/ms678486(v=vs.85).aspx Edge does not support drag and drop for pen neither. BUG=724836 ==========
On 2017/05/31 15:00:10, lanwei wrote: lgtm
The CQ bit was checked by lanwei@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1496247076441900, "parent_rev":
"1f326c6ec562cdbe58f9a958ca02758c620688d2", "commit_rev":
"984c0003a871be8eec92691961ae0617fe728fb1"}
Message was sent while issue was closed.
Description was changed from ========== Disable drag and drop when we use stylus on Windows Windows DoDragDrop function does not support invoking drag and drop support when we handle touch or pen input. If we want to support drag and drop for pen input, we have to listen to WM_MOUSE instead of WM_POINTER. https://msdn.microsoft.com/en-us/library/windows/desktop/ms678486(v=vs.85).aspx Edge does not support drag and drop for pen neither. BUG=724836 ========== to ========== Disable drag and drop when we use stylus on Windows Windows DoDragDrop function does not support invoking drag and drop support when we handle touch or pen input. If we want to support drag and drop for pen input, we have to listen to WM_MOUSE instead of WM_POINTER. https://msdn.microsoft.com/en-us/library/windows/desktop/ms678486(v=vs.85).aspx Edge does not support drag and drop for pen neither. BUG=724836 Review-Url: https://codereview.chromium.org/2911413002 Cr-Commit-Position: refs/heads/master@{#475934} Committed: https://chromium.googlesource.com/chromium/src/+/984c0003a871be8eec92691961ae... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/984c0003a871be8eec92691961ae... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
