Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2976743002: Sort generated messages. (Closed)

Created:
3 years, 5 months ago by ahe
Modified:
3 years, 5 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+876 lines, -874 lines) Patch
M pkg/front_end/lib/src/fasta/fasta_codes_generated.dart View 7 chunks +872 lines, -872 lines 0 comments Download
M pkg/front_end/tool/_fasta/generate_messages.dart View 1 chunk +4 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 5 (2 generated)
ahe
I'm seeing spurious reordering in another CL, so I decided to sort the keys explicitly.
3 years, 5 months ago (2017-07-11 13:33:06 UTC) #2
Johnni Winther
lgtm
3 years, 5 months ago (2017-07-11 18:35:55 UTC) #3
ahe
3 years, 5 months ago (2017-07-12 15:43:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
619006eac3414f77cb571bf4a89e15f6b862fa99 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698