Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2976623002: scheduler: Move IsJobOwner to acl package. (Closed)

Created:
3 years, 5 months ago by tandrii(chromium)
Modified:
3 years, 5 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : missing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -40 lines) Patch
A + scheduler/appengine/acl/acl.go View 1 3 chunks +2 lines, -3 lines 0 comments Download
M scheduler/appengine/apiservers/scheduler.go View 1 2 2 chunks +2 lines, -1 line 0 comments Download
D scheduler/appengine/presentation/acl.go View 1 1 chunk +0 lines, -31 lines 0 comments Download
M scheduler/appengine/ui/invocation.go View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scheduler/appengine/ui/job.go View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
tandrii(chromium)
ptal
3 years, 5 months ago (2017-07-18 18:08:41 UTC) #3
Vadim Sh.
lgtm
3 years, 5 months ago (2017-07-18 19:18:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2976623002/40001
3 years, 5 months ago (2017-07-19 10:49:16 UTC) #13
commit-bot: I haz the power
3 years, 5 months ago (2017-07-19 10:56:32 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://github.com/luci/luci-go/commit/1291040682d23ae49ab28d32bfe6781136aedbf1

Powered by Google App Engine
This is Rietveld 408576698