scheduler: Move IsJobOwner to acl package.

scheduler/appengine/ui/invocation.go

 // Copyright 2015 The LUCI Authors.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //      http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
 package ui
 
 import (
         "fmt"
         "net/http"
         "strconv"
         "sync"
 
         "github.com/luci/luci-go/server/auth"
         "github.com/luci/luci-go/server/router"
         "github.com/luci/luci-go/server/templates"
 
+        "github.com/luci/luci-go/scheduler/appengine/acl"
         "github.com/luci/luci-go/scheduler/appengine/engine"
-        "github.com/luci/luci-go/scheduler/appengine/presentation"
 )
 
 func invocationPage(c *router.Context) {
         projectID := c.Params.ByName("ProjectID")
         jobName := c.Params.ByName("JobName")
         invID, err := strconv.ParseInt(c.Params.ByName("InvID"), 10, 64)
         if err != nil {
                 http.Error(c.Writer, "No such invocation", http.StatusNotFound)
                 return
         }
@@ skipping 45 matching lines @@
         handleInvAction(c, func(jobID string, invID int64) error {
                 who := auth.CurrentIdentity(c.Context)
                 return config(c.Context).Engine.AbortInvocation(c.Context, jobID, invID, who)
         })
 }
 
 func handleInvAction(c *router.Context, cb func(string, int64) error) {
         projectID := c.Params.ByName("ProjectID")
         jobName := c.Params.ByName("JobName")
         invID := c.Params.ByName("InvID")
-        if !presentation.IsJobOwner(c.Context, projectID, jobName) {
+        if !acl.IsJobOwner(c.Context, projectID, jobName) {
                 http.Error(c.Writer, "Forbidden", 403)
                 return
         }
         invIDAsInt, err := strconv.ParseInt(invID, 10, 64)
         if err != nil {
                 http.Error(c.Writer, "Bad invocation ID", 400)
                 return
         }
         if err := cb(projectID+"/"+jobName, invIDAsInt); err != nil {
                 panic(err)
         }
         http.Redirect(c.Writer, c.Request, fmt.Sprintf("/jobs/%s/%s/%s", projectID, jobName, invID), http.StatusFound)
 }