Milo: Fix ?limit= param

Milo: Fix ?limit= param

This is actually a query (form) parameter, not a router parameter.

BUG=745757
Review-Url: https://codereview.chromium.org/2976393002
Committed: https://github.com/luci/luci-go/commit/746d72c63ab1f6cd0911794ffba1ce8dc60f4f8f

[Ryan Tseng, 2017-07-18 23:11:54]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-07-18 23:12:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ryan Tseng, 2017-07-18 23:12:47]

hinoka@google.com changed reviewers:
+ iannucci@chromium.org

[Ryan Tseng, 2017-07-18 23:12:47]

I missed this on review... ptal.

[commit-bot: I haz the power, 2017-07-18 23:18:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-18 23:18:16]

Dry run: This issue passed the CQ dry run.

[iannucci, 2017-07-19 00:04:57]

lgtm

https://codereview.chromium.org/2976393002/diff/1/milo/frontend/view_builder.go
File milo/frontend/view_builder.go (right):

https://codereview.chromium.org/2976393002/diff/1/milo/frontend/view_builder....
milo/frontend/view_builder.go:17: if tLimit, err := GetLimit(c.Request); err ==
nil {
make this take a default and not return error

[Ryan Tseng, 2017-07-19 00:12:04]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-07-19 00:12:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ryan Tseng, 2017-07-19 00:12:30]

https://codereview.chromium.org/2976393002/diff/1/milo/frontend/view_builder.go
File milo/frontend/view_builder.go (right):

https://codereview.chromium.org/2976393002/diff/1/milo/frontend/view_builder....
milo/frontend/view_builder.go:17: if tLimit, err := GetLimit(c.Request); err ==
nil {
On 2017/07/19 00:04:57, iannucci wrote:
> make this take a default and not return error

Done.

[Ryan Tseng, 2017-07-19 00:12:34]

The CQ bit was unchecked by hinoka@google.com

[Ryan Tseng, 2017-07-19 00:12:37]

The CQ bit was checked by hinoka@google.com

[Ryan Tseng, 2017-07-19 00:12:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
iannucci@chromium.org
Link to the patchset: https://codereview.chromium.org/2976393002/#ps20001
(title: "review")

[commit-bot: I haz the power, 2017-07-19 00:12:47]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-19 00:17:57]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1500423157907250,
"parent_rev": "c73a01793deb23192570c36c44c1a3978d4eb0db", "commit_rev":
"746d72c63ab1f6cd0911794ffba1ce8dc60f4f8f"}

[commit-bot: I haz the power, 2017-07-19 00:18:01]

Description was changed from

==========
Milo: Fix ?limit= param

This is actually a query (form) parameter, not a router parameter.

BUG=745757
==========

to

==========
Milo: Fix ?limit= param

This is actually a query (form) parameter, not a router parameter.

BUG=745757

Review-Url: https://codereview.chromium.org/2976393002
Committed:
https://github.com/luci/luci-go/commit/746d72c63ab1f6cd0911794ffba1ce8dc60f4f8f
==========

[commit-bot: I haz the power, 2017-07-19 00:18:02]

Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/746d72c63ab1f6cd0911794ffba1ce8dc60f4f8f