Milo: Fix ?limit= param

milo/buildsource/builder.go

 // Copyright 2017 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package buildsource
 
 import (
-        "strconv"
         "strings"
 
         "golang.org/x/net/context"
 
         "github.com/luci/gae/service/datastore"
 
         "github.com/luci/luci-go/common/errors"
-        "github.com/luci/luci-go/common/logging"
         "github.com/luci/luci-go/milo/api/resp"
         "github.com/luci/luci-go/milo/buildsource/buildbot"
         "github.com/luci/luci-go/milo/buildsource/buildbucket"
         "github.com/luci/luci-go/milo/common"
 )
 
 // BuilderID is the universal ID of a builder, and has the form:
 //   buildbucket/bucket/builder
 //   buildbot/master/builder
 type BuilderID string
@@ skipping 26 matching lines @@
         }
         if builderName == "" {
                 err = errors.New("bad BuilderID: empty builderName", common.CodeParameterError)
                 return
         }
         return
 }
 
 // Get allows you to obtain the resp.Builder that corresponds with this
 // BuilderID.
-func (b BuilderID) Get(c context.Context, limitStr string, cursorStr string) (*resp.Builder, error) {
+func (b BuilderID) Get(c context.Context, limit int, cursorStr string) (*resp.Builder, error) {
         // TODO(iannucci): replace these implementations with a BuildSummary query.
-
-        limit := 0
-        if limitStr != "" {
-                switch limitVal, err := strconv.ParseInt(limitStr, 10, 0); err {
-                case nil:
-                        limit = int(limitVal)
-                default:
-                        logging.WithError(err).Warningf(c, "ignoring bad limit %q", limitStr)
-                }
-        }
-        if limit <= 0 {
-                limit = 25
-        }
-
         source, group, builder, err := b.Split()
         if err != nil {
                 return nil, err
         }
 
         switch source {
         case "buildbot":
                 cursor, err := datastore.DecodeCursor(c, cursorStr)
                 if err != nil {
                         return nil, errors.Annotate(err, "bad cursor").Err()
                 }
                 return buildbot.GetBuilder(c, group, builder, limit, cursor)
 
         case "buildbucket":
                 return buildbucket.GetBuilder(c, group, builder, limit)
         }
 
         panic("impossible")
 }