Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 2975913002: Temporarily back out newly introduced assertions to fix buildbots (Closed)

Created:
3 years, 5 months ago by alexmarkov
Modified:
3 years, 5 months ago
Reviewers:
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Temporarily back out newly introduced assertions to fix buildbots These assertions where recently added as the part of implementation of truncating integer arithmetic to 64 bits. They check invariants for the existing implementation of shifts. So far, there are several failures on IA32 and ARM. Commenting out these assertions while investigating to make buildbots green. TBR Committed: https://github.com/dart-lang/sdk/commit/8fb4aaa132564245c13de8d2030a3132089b9da4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M runtime/vm/intermediate_language_arm.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
alexmarkov
3 years, 5 months ago (2017-07-11 16:36:56 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8fb4aaa132564245c13de8d2030a3132089b9da4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698